[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qapi: Fix code generation with Python 3.5
From: |
Markus Armbruster |
Subject: |
Re: [PATCH] qapi: Fix code generation with Python 3.5 |
Date: |
Fri, 17 Jan 2020 08:07:42 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
John Snow <address@hidden> writes:
> On 1/16/20 3:25 PM, Markus Armbruster wrote:
>> Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules"
>> modules" switched QAPISchema.visit() from
>>
>> for entity in self._entity_list:
>>
>> effectively to
>>
>> for mod in self._module_dict.values():
>> for entity in mod._entity_list:
>>
>> Visits in the same order as long as .values() is in insertion order.
>> That's the case only for Python 3.6 and later. Before, it's in some
>> arbitrary order, which results in broken generated code.
>>
>> Fix by making self._module_dict an OrderedDict rather than a dict.
>>
>> Fixes: 3e7fb5811baab213dcc7149c3aa69442d683c26c
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> scripts/qapi/schema.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
>> index 0bfc5256fb..5100110fa2 100644
>> --- a/scripts/qapi/schema.py
>> +++ b/scripts/qapi/schema.py
>> @@ -795,7 +795,7 @@ class QAPISchema(object):
>> self.docs = parser.docs
>> self._entity_list = []
>> self._entity_dict = {}
>> - self._module_dict = {}
>> + self._module_dict = OrderedDict()
>> self._schema_dir = os.path.dirname(fname)
>> self._make_module(None) # built-ins
>> self._make_module(fname)
>>
>
> This problem has bitten me *many* times. I'm wondering if there's a
> prescription that isn't just "Wait until we can stipulate 3.6+".
No clue.
3.5 EOL is scheduled for 2020-09-13.
https://devguide.python.org/#status-of-python-branches
We support 3.5 because we support Debian 9.
We'd normally drop support for Debian 9 two years after Debian 10,
i.e. July 2021. Assuming Debian supports it that far. Whether they can
truly support Python 3.5 after uptstream EOL seems doubtful.
Re: [PATCH] qapi: Fix code generation with Python 3.5, Thomas Huth, 2020/01/17
Re: [PATCH] qapi: Fix code generation with Python 3.5, Alex Bennée, 2020/01/20
Re: [PATCH] qapi: Fix code generation with Python 3.5, Peter Maydell, 2020/01/20