Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

[Dr. David Alan Gilbert]

* Miklos Szeredi (address@hidden) wrote:
> On Thu, Jan 16, 2020 at 5:45 PM Dr. David Alan Gilbert
> <address@hidden> wrote:
> >
> > * Misono Tomohiro (address@hidden) wrote:
> > > > From: Miklos Szeredi <address@hidden>
> > > >
> > > > Signed-off-by: Miklos Szeredi <address@hidden>
> > >
> > > I'm not familiar with qemu convention but shouldn't we put
> > > at least one line of description like linux kernel?
> >
> > Miklos: would you like to suggest a better commit message?
> 
> Hmm, the patch doesn't really make sense, since the looked up inode is not 
> used.
> 
> Not sure what happened here, this seems to be for supporting shared
> versions, and these changes are part of commit 06f78a397f00
> ("virtiofsd: add initial support for shared versions") in our gitlab
> qemu tree.  Was this intentionally split out?

I think the reason I kept this here is because Stefan's
  'introduce inode refcount to prevent use-after-free'

does use the the inodes in lo_rename; is it also dependent on having
done the in lo_rmdir and lo_unlink?

Dave


> Thanks,
> Miklos
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK