[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove
From: |
Miklos Szeredi |
Subject: |
Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename |
Date: |
Fri, 17 Jan 2020 11:19:43 +0100 |
On Thu, Jan 16, 2020 at 5:45 PM Dr. David Alan Gilbert
<address@hidden> wrote:
>
> * Misono Tomohiro (address@hidden) wrote:
> > > From: Miklos Szeredi <address@hidden>
> > >
> > > Signed-off-by: Miklos Szeredi <address@hidden>
> >
> > I'm not familiar with qemu convention but shouldn't we put
> > at least one line of description like linux kernel?
>
> Miklos: would you like to suggest a better commit message?
Hmm, the patch doesn't really make sense, since the looked up inode is not used.
Not sure what happened here, this seems to be for supporting shared
versions, and these changes are part of commit 06f78a397f00
("virtiofsd: add initial support for shared versions") in our gitlab
qemu tree. Was this intentionally split out?
Thanks,
Miklos