Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
11a20c3 numa: remove deprecated implicit RAM distribution between nodes
d86b08b numa: make exit() usage consistent
8646e5e tests:numa-test: use explicit memdev to specify node RAM
e73639d tests:numa-test: make top level args dynamic and g_autofree(cli) 
cleanups
22e8003 numa: forbid '-numa node, mem' for 5.0 and newer machine types
4636732 hostmem: fix strict bind policy
547e119 hostmem: introduce "prealloc-threads" property
37e2c24 make mem_path local variable
3f12da2 exec: drop bogus mem_path from qemu_ram_alloc_from_fd()
82d8312 exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
fad9d83 post conversion default_ram_id cleanup
dba7fdb remove no longer used memory_region_allocate_system_memory()
b3cee01 sparc:niagara: use memdev for RAM
193cdb5 sparc:sun4m: use memdev for RAM
7b57adc sparc:leon3: use memdev for RAM
1b43407 ppc:virtex_ml507: use memdev for RAM
d151f5a ppc:virtex_ml507: remove unused arguments
9696d27 ppc:spapr: use memdev for RAM
42503a2 ppc:prep: use memdev for RAM
07bab1c ppc:ppc440_bamboo/sam460ex: use memdev for RAM
78dacf7 ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup
c946d56 ppc:ppc405_boards: use memdev for RAM
90799d8 ppc:ppc405_boards: add RAM size checks
95965c8 ppc:pnv: use memdev for RAM
8794a61 ppc:mac_oldworld: use memdev for RAM
803a239 ppc:mac_newworld: use memdev for RAM
de3715d ppc:e500: use memdev for RAM
aa12e5f ppc:e500: drop RAM size fixup
05ef318 mips:mips_r4k: use memdev for RAM
0577baa mips:mips_mipssim: use memdev for RAM
a1226bd mips:mips_malta: use memdev for RAM
f059e6d mips:mips_jazz: use memdev for RAM
9fde8b0 mips:mips_fulong2e: use memdev for RAM
974b1c0 mips:mips_fulong2e: drop RAM size fixup
6f147f5 mips:boston-cube: use memdev for RAM
f97cebd m68k:next-cube: use memdev for RAM
aa9050c m68k:mcf5208: use memdev for RAM
2e37399 m68k:an5206: use memdev for RAM
7471a18 lm32:milkymist: use memdev for RAM
06d3b1b lm32:lm32_boards: use memdev for RAM
b72206f x86:pc: use memdev for RAM
f0ed8ae x86:microvm: use memdev for RAM
56cec52 hppa: use memdev for RAM
dad8af3 hw/hppa/machine: Map the PDC memory region with higher priority
14d9db7 hw/hppa/machine: Restrict the total memory size to 3GB
8bb59b8 hw/hppa/machine: Correctly check the firmware is in PDC range
f66c661 cris:axis_dev88: use memdev for RAM
30ec2c7 null-machine: use memdev for RAM
eca7ad3 s390x:s390-virtio-ccw: use memdev for RAM
9efacaa arm:xlnx-zcu102: use memdev for RAM
6c17f5e arm:xlnx-versal-virt: use memdev for RAM
c974680 arm:xilinx_zynq: use memdev for RAM
5214578 arm:xilinx_zynq: drop RAM size fixup
487a287 arm:virt: use memdev for RAM
f59a421 arm:vexpress: use memdev for RAM
5f18495 arm:versatilepb: use memdev for RAM
4ef5f91 arm:sbsa-ref: use memdev for RAM
e67a909 arm:sabrelite: use memdev for RAM
8b211a1 arm:raspi: use memdev for RAM
c2fe517 arm:palm: use memdev for RAM
59fa4ec arm:omap_sx1: use memdev for RAM
54372f1 arm:nseries: use memdev for RAM
a460240 arm:musicpal: use memdev for RAM
00a31d8 arm:mps2: use memdev for RAM
6384dde arm:mps2-tz: use memdev for RAM
d675a78 arm:mcimx7d-sabre: use memdev for RAM
a5d1f43 arm:mcimx6ul-evk: use memdev for RAM
e5d7dc1 arm:kzm: use memdev for RAM
c3cc180 arm:kzm: drop RAM size fixup
f843b3e arm:integratorcp: use memdev for RAM
4dee2dc arm:imx25_pdk: use memdev for RAM
c794dcf arm:imx25_pdk: drop RAM size fixup
999f220 arm:highbank: use memdev for RAM
91d80f4 arm:digic_boards: use memdev for RAM
aab50b1 arm:cubieboard: use memdev for RAM
8d954fe arm:collie: use memdev for RAM
7b0d326 arm:aspeed: use memdev for RAM
6a7c2af hw:aspeed: drop warning and bogus ram_size fixup
172ef43 arm:aspeed: actually check RAM size
0e55e08 arm:aspeed: convert valid RAM sizes to data
ff6444e alpha:dp264: use memdev for RAM
b02edb3 initialize MachineState::ram in NUMA case
5d0b636 machine: introduce convenience MachineState::ram
0fc2004 machine: alias -mem-path and -mem-prealloc into memory-foo backend
6d984b5 machine: introduce ram-memdev property
08fae89 numa: remove deprecated -mem-path fallback to anonymous RAM

=== OUTPUT BEGIN ===
1/86 Checking commit 08fae890b67d (numa: remove deprecated -mem-path fallback 
to anonymous RAM)
2/86 Checking commit 6d984b5dbe35 (machine: introduce ram-memdev property)
3/86 Checking commit 0fc2004b03fa (machine: alias -mem-path and -mem-prealloc 
into memory-foo backend)
4/86 Checking commit 5d0b6369dddd (machine: introduce convenience 
MachineState::ram)
5/86 Checking commit b02edb340b79 (initialize MachineState::ram in NUMA case)
6/86 Checking commit ff6444e72906 (alpha:dp264: use memdev for RAM)
ERROR: spaces required around that '*' (ctx:WxV)
#30: FILE: hw/alpha/alpha_sys.h:14:
+PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4],
                                                                      ^

total: 1 errors, 0 warnings, 49 lines checked

Patch 6/86 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/86 Checking commit 0e55e08f3939 (arm:aspeed: convert valid RAM sizes to data)
8/86 Checking commit 172ef43b9b4c (arm:aspeed: actually check RAM size)
9/86 Checking commit 6a7c2afd4d79 (hw:aspeed: drop warning and bogus ram_size 
fixup)
10/86 Checking commit 7b0d32621113 (arm:aspeed: use memdev for RAM)
11/86 Checking commit 8d954fe5f96f (arm:collie: use memdev for RAM)
12/86 Checking commit aab50b18bced (arm:cubieboard: use memdev for RAM)
13/86 Checking commit 91d80f466fe8 (arm:digic_boards: use memdev for RAM)
14/86 Checking commit 999f220da883 (arm:highbank: use memdev for RAM)
15/86 Checking commit c794dcf7bf01 (arm:imx25_pdk: drop RAM size fixup)
16/86 Checking commit 4dee2dcc09ca (arm:imx25_pdk: use memdev for RAM)
17/86 Checking commit f843b3e1c9f9 (arm:integratorcp: use memdev for RAM)
18/86 Checking commit c3cc18081f36 (arm:kzm: drop RAM size fixup)
19/86 Checking commit e5d7dc1e5edf (arm:kzm: use memdev for RAM)
20/86 Checking commit a5d1f434a0e5 (arm:mcimx6ul-evk: use memdev for RAM)
21/86 Checking commit d675a780389d (arm:mcimx7d-sabre: use memdev for RAM)
22/86 Checking commit 6384dde578a1 (arm:mps2-tz: use memdev for RAM)
23/86 Checking commit 00a31d86e9a8 (arm:mps2: use memdev for RAM)
24/86 Checking commit a4602403859e (arm:musicpal: use memdev for RAM)
25/86 Checking commit 54372f185c92 (arm:nseries: use memdev for RAM)
26/86 Checking commit 59fa4ec0862b (arm:omap_sx1: use memdev for RAM)
27/86 Checking commit c2fe517abcc9 (arm:palm: use memdev for RAM)
28/86 Checking commit 8b211a1daf3d (arm:raspi: use memdev for RAM)
29/86 Checking commit e67a9091bf3d (arm:sabrelite: use memdev for RAM)
30/86 Checking commit 4ef5f91d1d96 (arm:sbsa-ref: use memdev for RAM)
31/86 Checking commit 5f184952ed5b (arm:versatilepb: use memdev for RAM)
32/86 Checking commit f59a42177faf (arm:vexpress: use memdev for RAM)
33/86 Checking commit 487a287b51b3 (arm:virt: use memdev for RAM)
34/86 Checking commit 521457884d96 (arm:xilinx_zynq: drop RAM size fixup)
35/86 Checking commit c9746806716e (arm:xilinx_zynq: use memdev for RAM)
36/86 Checking commit 6c17f5ec4b48 (arm:xlnx-versal-virt: use memdev for RAM)
37/86 Checking commit 9efacaa92b99 (arm:xlnx-zcu102: use memdev for RAM)
38/86 Checking commit eca7ad3c361e (s390x:s390-virtio-ccw: use memdev for RAM)
39/86 Checking commit 30ec2c7dc4c1 (null-machine: use memdev for RAM)
40/86 Checking commit f66c661dad7f (cris:axis_dev88: use memdev for RAM)
41/86 Checking commit 8bb59b8d7d9b (hw/hppa/machine: Correctly check the 
firmware is in PDC range)
42/86 Checking commit 14d9db719ee9 (hw/hppa/machine: Restrict the total memory 
size to 3GB)
43/86 Checking commit dad8af336ab4 (hw/hppa/machine: Map the PDC memory region 
with higher priority)
44/86 Checking commit 56cec5259b48 (hppa: use memdev for RAM)
45/86 Checking commit f0ed8aea05ec (x86:microvm: use memdev for RAM)
46/86 Checking commit b72206fa355a (x86:pc: use memdev for RAM)
47/86 Checking commit 06d3b1b78666 (lm32:lm32_boards: use memdev for RAM)
48/86 Checking commit 7471a180c3a6 (lm32:milkymist: use memdev for RAM)
49/86 Checking commit 2e3739900bd8 (m68k:an5206: use memdev for RAM)
50/86 Checking commit aa9050cb0d06 (m68k:mcf5208: use memdev for RAM)
51/86 Checking commit f97cebd672df (m68k:next-cube: use memdev for RAM)
52/86 Checking commit 6f147f566f68 (mips:boston-cube: use memdev for RAM)
53/86 Checking commit 974b1c015a30 (mips:mips_fulong2e: drop RAM size fixup)
54/86 Checking commit 9fde8b0b7ebd (mips:mips_fulong2e: use memdev for RAM)
55/86 Checking commit f059e6d82739 (mips:mips_jazz: use memdev for RAM)
56/86 Checking commit a1226bd6ef36 (mips:mips_malta: use memdev for RAM)
57/86 Checking commit 0577baa20231 (mips:mips_mipssim: use memdev for RAM)
58/86 Checking commit 05ef318bd0cc (mips:mips_r4k: use memdev for RAM)
59/86 Checking commit aa12e5f0638e (ppc:e500: drop RAM size fixup)
60/86 Checking commit de3715db85f6 (ppc:e500: use memdev for RAM)
61/86 Checking commit 803a2393fc14 (ppc:mac_newworld: use memdev for RAM)
62/86 Checking commit 8794a61a8dde (ppc:mac_oldworld: use memdev for RAM)
63/86 Checking commit 95965c87139d (ppc:pnv: use memdev for RAM)
64/86 Checking commit 90799d8e395f (ppc:ppc405_boards: add RAM size checks)
65/86 Checking commit c946d56eda0e (ppc:ppc405_boards: use memdev for RAM)
66/86 Checking commit 78dacf71acea (ppc/{ppc440_bamboo,sam460x}: drop RAM size 
fixup)
67/86 Checking commit 07bab1c01b30 (ppc:ppc440_bamboo/sam460ex: use memdev for 
RAM)
68/86 Checking commit 42503a255083 (ppc:prep: use memdev for RAM)
69/86 Checking commit 9696d2717401 (ppc:spapr: use memdev for RAM)
70/86 Checking commit d151f5a5742e (ppc:virtex_ml507: remove unused arguments)
71/86 Checking commit 1b434072e43b (ppc:virtex_ml507: use memdev for RAM)
72/86 Checking commit 7b57adc2d77a (sparc:leon3: use memdev for RAM)
73/86 Checking commit 193cdb51d4bf (sparc:sun4m: use memdev for RAM)
74/86 Checking commit b3cee011513d (sparc:niagara: use memdev for RAM)
75/86 Checking commit dba7fdb96a10 (remove no longer used 
memory_region_allocate_system_memory())
76/86 Checking commit fad9d8348bef (post conversion default_ram_id cleanup)
77/86 Checking commit 82d8312d1497 (exec: cleanup 
qemu_minrampagesize()/qemu_maxrampagesize())
78/86 Checking commit 3f12da229964 (exec: drop bogus mem_path from 
qemu_ram_alloc_from_fd())
79/86 Checking commit 37e2c242f0f5 (make mem_path local variable)
80/86 Checking commit 547e1199adae (hostmem: introduce "prealloc-threads" 
property)
81/86 Checking commit 46367323657c (hostmem: fix strict bind policy)
82/86 Checking commit 22e8003d2397 (numa: forbid '-numa node, mem' for 5.0 and 
newer machine types)
83/86 Checking commit e73639dfcea1 (tests:numa-test: make top level args 
dynamic and g_autofree(cli) cleanups)
84/86 Checking commit 8646e5e3e3b3 (tests:numa-test: use explicit memdev to 
specify node RAM)
85/86 Checking commit d86b08b42b99 (numa: make exit() usage consistent)
86/86 Checking commit 11a20c3ae98b (numa: remove deprecated implicit RAM 
distribution between nodes)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden