Re: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 00/86] refactor main RAM allocation to use hostmem backend
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
1209a36 numa: remove deprecated implicit RAM distribution between nodes
19d06fb numa: make exit() usage consistent
7f1c3cb tests:numa-test: use explicit memdev to specify node RAM
1f9e2a0 tests:numa-test: make top level args dynamic and g_autofree(cli) 
cleanups
599a9d5 numa: forbid '-numa node, mem' for 5.0 and newer machine types
abc7dcb hostmem: fix strict bind policy
f128425 hostmem: introduce "prealloc-threads" property
29a5753 make mem_path local variable
9c8eede exec: drop bogus mem_path from qemu_ram_alloc_from_fd()
ae8a358 exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()
bd38eb7 post conversion default_ram_id cleanup
531214b remove no longer used memory_region_allocate_system_memory()
9aa9b21 sparc:niagara: use memdev for RAM
7501234 sparc:sun4m: use memdev for RAM
362d299 sparc:leon3: use memdev for RAM
3d80e73 ppc:virtex_ml507: use memdev for RAM
3f9b614 ppc:virtex_ml507: remove unused arguments
23206b2 ppc:spapr: use memdev for RAM
21d8ec6 ppc:prep: use memdev for RAM
b2dfc41 ppc:ppc440_bamboo/sam460ex: use memdev for RAM
f7dba1d ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup
6797fc9 ppc:ppc405_boards: use memdev for RAM
6589023 ppc:ppc405_boards: add RAM size checks
f4e844d ppc:pnv: use memdev for RAM
7a5c1e0 ppc:mac_oldworld: use memdev for RAM
c0070ff ppc:mac_newworld: use memdev for RAM
891c437 ppc:e500: use memdev for RAM
e356db0 ppc:e500: drop RAM size fixup
d9d748a mips:mips_r4k: use memdev for RAM
c3aeedd mips:mips_mipssim: use memdev for RAM
f1ae813 mips:mips_malta: use memdev for RAM
8135812 mips:mips_jazz: use memdev for RAM
6bb5173 mips:mips_fulong2e: use memdev for RAM
7918bc6 mips:mips_fulong2e: drop RAM size fixup
03ed964 mips:boston-cube: use memdev for RAM
50de1db m68k:next-cube: use memdev for RAM
11359d6 m68k:mcf5208: use memdev for RAM
0f6e187 m68k:an5206: use memdev for RAM
1dbf590 lm32:milkymist: use memdev for RAM
1ec9f92 lm32:lm32_boards: use memdev for RAM
cfda441 x86:pc: use memdev for RAM
cf3880a x86:microvm: use memdev for RAM
bd518f7 hppa: use memdev for RAM
4fc8795 hw/hppa/machine: Map the PDC memory region with higher priority
8198bbb hw/hppa/machine: Restrict the total memory size to 3GB
b734915 hw/hppa/machine: Correctly check the firmware is in PDC range
f132881 cris:axis_dev88: use memdev for RAM
afed772 null-machine: use memdev for RAM
42efb21 s390x:s390-virtio-ccw: use memdev for RAM
e09d9d5 arm:xlnx-zcu102: use memdev for RAM
f4cfdc5 arm:xlnx-versal-virt: use memdev for RAM
27cb15f arm:xilinx_zynq: use memdev for RAM
c4d7543 arm:xilinx_zynq: drop RAM size fixup
4cee731 arm:virt: use memdev for RAM
bc8706f arm:vexpress: use memdev for RAM
8f9a8d5 arm:versatilepb: use memdev for RAM
7534670 arm:sbsa-ref: use memdev for RAM
f7a5bd5 arm:sabrelite: use memdev for RAM
c543136 arm:raspi: use memdev for RAM
1980a99 arm:palm: use memdev for RAM
f2a8a27 arm:omap_sx1: use memdev for RAM
83e43bd arm:nseries: use memdev for RAM
ce56f6f arm:musicpal: use memdev for RAM
8d8a3df arm:mps2: use memdev for RAM
cde4e5c arm:mps2-tz: use memdev for RAM
496e1ec arm:mcimx7d-sabre: use memdev for RAM
107798d arm:mcimx6ul-evk: use memdev for RAM
2aad52a arm:kzm: use memdev for RAM
931e8ed arm:kzm: drop RAM size fixup
3a6db19 arm:integratorcp: use memdev for RAM
7027643 arm:imx25_pdk: use memdev for RAM
34af242 arm:imx25_pdk: drop RAM size fixup
40d5268 arm:highbank: use memdev for RAM
7b39bf2 arm:digic_boards: use memdev for RAM
4ce882d arm:cubieboard: use memdev for RAM
9e5f1e4 arm:collie: use memdev for RAM
4271c25 arm:aspeed: use memdev for RAM
51eb68b hw:aspeed: drop warning and bogus ram_size fixup
d19f874 arm:aspeed: actually check RAM size
5e95ab5 arm:aspeed: convert valid RAM sizes to data
b9b1823 alpha:dp264: use memdev for RAM
54d3324 initialize MachineState::ram in NUMA case
a905e67 machine: introduce convenience MachineState::ram
c4baa19 machine: alias -mem-path and -mem-prealloc into memory-foo backend
f4626dd machine: introduce ram-memdev property
c37dfff numa: remove deprecated -mem-path fallback to anonymous RAM

=== OUTPUT BEGIN ===
1/86 Checking commit c37dfffa4efd (numa: remove deprecated -mem-path fallback 
to anonymous RAM)
2/86 Checking commit f4626dd69b26 (machine: introduce ram-memdev property)
3/86 Checking commit c4baa192a911 (machine: alias -mem-path and -mem-prealloc 
into memory-foo backend)
4/86 Checking commit a905e67b7c6f (machine: introduce convenience 
MachineState::ram)
5/86 Checking commit 54d3324c4016 (initialize MachineState::ram in NUMA case)
6/86 Checking commit b9b1823833a3 (alpha:dp264: use memdev for RAM)
ERROR: spaces required around that '*' (ctx:WxV)
#30: FILE: hw/alpha/alpha_sys.h:14:
+PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4],
                                                                      ^

total: 1 errors, 0 warnings, 49 lines checked

Patch 6/86 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/86 Checking commit 5e95ab5c9cbf (arm:aspeed: convert valid RAM sizes to data)
8/86 Checking commit d19f87410bb0 (arm:aspeed: actually check RAM size)
9/86 Checking commit 51eb68b5b6dd (hw:aspeed: drop warning and bogus ram_size 
fixup)
10/86 Checking commit 4271c257d2dc (arm:aspeed: use memdev for RAM)
11/86 Checking commit 9e5f1e40a8a1 (arm:collie: use memdev for RAM)
12/86 Checking commit 4ce882df0248 (arm:cubieboard: use memdev for RAM)
13/86 Checking commit 7b39bf2154ee (arm:digic_boards: use memdev for RAM)
14/86 Checking commit 40d526890ff2 (arm:highbank: use memdev for RAM)
15/86 Checking commit 34af2429cba4 (arm:imx25_pdk: drop RAM size fixup)
16/86 Checking commit 702764368746 (arm:imx25_pdk: use memdev for RAM)
17/86 Checking commit 3a6db19653b8 (arm:integratorcp: use memdev for RAM)
18/86 Checking commit 931e8edc73be (arm:kzm: drop RAM size fixup)
19/86 Checking commit 2aad52a98a7f (arm:kzm: use memdev for RAM)
20/86 Checking commit 107798df7551 (arm:mcimx6ul-evk: use memdev for RAM)
21/86 Checking commit 496e1ec4c802 (arm:mcimx7d-sabre: use memdev for RAM)
22/86 Checking commit cde4e5c62e6c (arm:mps2-tz: use memdev for RAM)
23/86 Checking commit 8d8a3df592ff (arm:mps2: use memdev for RAM)
24/86 Checking commit ce56f6fa5c27 (arm:musicpal: use memdev for RAM)
25/86 Checking commit 83e43bd9c245 (arm:nseries: use memdev for RAM)
26/86 Checking commit f2a8a2703e2c (arm:omap_sx1: use memdev for RAM)
27/86 Checking commit 1980a9933328 (arm:palm: use memdev for RAM)
28/86 Checking commit c54313643e04 (arm:raspi: use memdev for RAM)
29/86 Checking commit f7a5bd5a1a37 (arm:sabrelite: use memdev for RAM)
30/86 Checking commit 75346700226a (arm:sbsa-ref: use memdev for RAM)
31/86 Checking commit 8f9a8d5832e9 (arm:versatilepb: use memdev for RAM)
32/86 Checking commit bc8706f5e2d5 (arm:vexpress: use memdev for RAM)
33/86 Checking commit 4cee731800bb (arm:virt: use memdev for RAM)
34/86 Checking commit c4d7543f065b (arm:xilinx_zynq: drop RAM size fixup)
35/86 Checking commit 27cb15f0d997 (arm:xilinx_zynq: use memdev for RAM)
36/86 Checking commit f4cfdc5a94bb (arm:xlnx-versal-virt: use memdev for RAM)
37/86 Checking commit e09d9d544217 (arm:xlnx-zcu102: use memdev for RAM)
38/86 Checking commit 42efb216e23c (s390x:s390-virtio-ccw: use memdev for RAM)
39/86 Checking commit afed77250a9e (null-machine: use memdev for RAM)
40/86 Checking commit f132881e85cd (cris:axis_dev88: use memdev for RAM)
41/86 Checking commit b734915b4a79 (hw/hppa/machine: Correctly check the 
firmware is in PDC range)
42/86 Checking commit 8198bbbb80a8 (hw/hppa/machine: Restrict the total memory 
size to 3GB)
43/86 Checking commit 4fc879584148 (hw/hppa/machine: Map the PDC memory region 
with higher priority)
44/86 Checking commit bd518f7b1afe (hppa: use memdev for RAM)
45/86 Checking commit cf3880ae2cde (x86:microvm: use memdev for RAM)
46/86 Checking commit cfda4411481a (x86:pc: use memdev for RAM)
47/86 Checking commit 1ec9f92af351 (lm32:lm32_boards: use memdev for RAM)
48/86 Checking commit 1dbf590a6f2e (lm32:milkymist: use memdev for RAM)
49/86 Checking commit 0f6e18798454 (m68k:an5206: use memdev for RAM)
50/86 Checking commit 11359d6d7fca (m68k:mcf5208: use memdev for RAM)
51/86 Checking commit 50de1db70670 (m68k:next-cube: use memdev for RAM)
52/86 Checking commit 03ed96483838 (mips:boston-cube: use memdev for RAM)
53/86 Checking commit 7918bc615c00 (mips:mips_fulong2e: drop RAM size fixup)
54/86 Checking commit 6bb51739bef8 (mips:mips_fulong2e: use memdev for RAM)
55/86 Checking commit 8135812a7f8f (mips:mips_jazz: use memdev for RAM)
56/86 Checking commit f1ae813bc679 (mips:mips_malta: use memdev for RAM)
57/86 Checking commit c3aeedd1f9e7 (mips:mips_mipssim: use memdev for RAM)
58/86 Checking commit d9d748a3c5c4 (mips:mips_r4k: use memdev for RAM)
59/86 Checking commit e356db0d9dc1 (ppc:e500: drop RAM size fixup)
60/86 Checking commit 891c437f30de (ppc:e500: use memdev for RAM)
61/86 Checking commit c0070fff31f7 (ppc:mac_newworld: use memdev for RAM)
62/86 Checking commit 7a5c1e08eb9a (ppc:mac_oldworld: use memdev for RAM)
63/86 Checking commit f4e844d0b244 (ppc:pnv: use memdev for RAM)
64/86 Checking commit 6589023692a3 (ppc:ppc405_boards: add RAM size checks)
65/86 Checking commit 6797fc946c2f (ppc:ppc405_boards: use memdev for RAM)
66/86 Checking commit f7dba1dc9cee (ppc/{ppc440_bamboo,sam460x}: drop RAM size 
fixup)
67/86 Checking commit b2dfc417ea25 (ppc:ppc440_bamboo/sam460ex: use memdev for 
RAM)
68/86 Checking commit 21d8ec68c790 (ppc:prep: use memdev for RAM)
69/86 Checking commit 23206b2a4e7e (ppc:spapr: use memdev for RAM)
70/86 Checking commit 3f9b6144afb3 (ppc:virtex_ml507: remove unused arguments)
71/86 Checking commit 3d80e73f3489 (ppc:virtex_ml507: use memdev for RAM)
72/86 Checking commit 362d2997578e (sparc:leon3: use memdev for RAM)
73/86 Checking commit 7501234325d1 (sparc:sun4m: use memdev for RAM)
74/86 Checking commit 9aa9b2166491 (sparc:niagara: use memdev for RAM)
75/86 Checking commit 531214b20a79 (remove no longer used 
memory_region_allocate_system_memory())
76/86 Checking commit bd38eb7acb3b (post conversion default_ram_id cleanup)
77/86 Checking commit ae8a35855f2c (exec: cleanup 
qemu_minrampagesize()/qemu_maxrampagesize())
78/86 Checking commit 9c8eede386a4 (exec: drop bogus mem_path from 
qemu_ram_alloc_from_fd())
79/86 Checking commit 29a5753391ee (make mem_path local variable)
80/86 Checking commit f128425ba191 (hostmem: introduce "prealloc-threads" 
property)
81/86 Checking commit abc7dcbd0c46 (hostmem: fix strict bind policy)
82/86 Checking commit 599a9d539ae3 (numa: forbid '-numa node, mem' for 5.0 and 
newer machine types)
83/86 Checking commit 1f9e2a07e397 (tests:numa-test: make top level args 
dynamic and g_autofree(cli) cleanups)
84/86 Checking commit 7f1c3cb94728 (tests:numa-test: use explicit memdev to 
specify node RAM)
85/86 Checking commit 19d06fb502bb (numa: make exit() usage consistent)
86/86 Checking commit 1209a3623bcc (numa: remove deprecated implicit RAM 
distribution between nodes)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden