[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 26/86] arm:omap_sx1: use memdev for RAM
From: |
Igor Mammedov |
Subject: |
[PATCH v2 26/86] arm:omap_sx1: use memdev for RAM |
Date: |
Wed, 15 Jan 2020 16:06:41 +0100 |
memory_region_allocate_system_memory() API is going away, so
replace it with memdev allocated MemoryRegion. The later is
initialized by generic code, so board only needs to opt in
to memdev scheme by providing
MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing
RAM memory region.
PS:
while at it add check for user supplied RAM size and error
out if it mismatches board expected value.
Signed-off-by: Igor Mammedov <address@hidden>
---
v2:
* fix format string causing build failure on 32-bit host
(Philippe Mathieu-Daudé <address@hidden>)
CC: address@hidden
CC: address@hidden
---
hw/arm/omap_sx1.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c
index be24571..aa1831b 100644
--- a/hw/arm/omap_sx1.c
+++ b/hw/arm/omap_sx1.c
@@ -102,8 +102,8 @@ static struct arm_boot_info sx1_binfo = {
static void sx1_init(MachineState *machine, const int version)
{
struct omap_mpu_state_s *mpu;
+ MachineClass *mc = MACHINE_GET_CLASS(machine);
MemoryRegion *address_space = get_system_memory();
- MemoryRegion *dram = g_new(MemoryRegion, 1);
MemoryRegion *flash = g_new(MemoryRegion, 1);
MemoryRegion *cs = g_new(MemoryRegion, 4);
static uint32_t cs0val = 0x00213090;
@@ -115,15 +115,19 @@ static void sx1_init(MachineState *machine, const int
version)
uint32_t flash_size = flash0_size;
int be;
+ if (machine->ram_size != mc->default_ram_size) {
+ error_report("Invalid RAM size, should be " RAM_ADDR_UFMT " Bytes",
+ mc->default_ram_size);
+ exit(EXIT_FAILURE);
+ }
+
if (version == 2) {
flash_size = flash2_size;
}
- memory_region_allocate_system_memory(dram, NULL, "omap1.dram",
- sx1_binfo.ram_size);
- memory_region_add_subregion(address_space, OMAP_EMIFF_BASE, dram);
+ memory_region_add_subregion(address_space, OMAP_EMIFF_BASE, machine->ram);
- mpu = omap310_mpu_init(dram, machine->cpu_type);
+ mpu = omap310_mpu_init(machine->ram, machine->cpu_type);
/* External Flash (EMIFS) */
memory_region_init_ram(flash, NULL, "omap_sx1.flash0-0", flash_size,
@@ -223,6 +227,8 @@ static void sx1_machine_v2_class_init(ObjectClass *oc, void
*data)
mc->init = sx1_init_v2;
mc->ignore_memory_transaction_failures = true;
mc->default_cpu_type = ARM_CPU_TYPE_NAME("ti925t");
+ mc->default_ram_size = sdram_size;
+ mc->default_ram_id = "omap1.dram";
}
static const TypeInfo sx1_machine_v2_type = {
@@ -239,6 +245,8 @@ static void sx1_machine_v1_class_init(ObjectClass *oc, void
*data)
mc->init = sx1_init_v1;
mc->ignore_memory_transaction_failures = true;
mc->default_cpu_type = ARM_CPU_TYPE_NAME("ti925t");
+ mc->default_ram_size = sdram_size;
+ mc->default_ram_id = "omap1.dram";
}
static const TypeInfo sx1_machine_v1_type = {
--
2.7.4
- [PATCH v2 16/86] arm:imx25_pdk: use memdev for RAM, (continued)
- [PATCH v2 16/86] arm:imx25_pdk: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 15/86] arm:imx25_pdk: drop RAM size fixup, Igor Mammedov, 2020/01/15
- [PATCH v2 20/86] arm:mcimx6ul-evk: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 21/86] arm:mcimx7d-sabre: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 23/86] arm:mps2: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 22/86] arm:mps2-tz: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 24/86] arm:musicpal: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 25/86] arm:nseries: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 27/86] arm:palm: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 26/86] arm:omap_sx1: use memdev for RAM,
Igor Mammedov <=
- [PATCH v2 29/86] arm:sabrelite: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 28/86] arm:raspi: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 31/86] arm:versatilepb: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 30/86] arm:sbsa-ref: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 32/86] arm:vexpress: use memdev for RAM, Igor Mammedov, 2020/01/15