[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm: adjust program counter for wfi exception in AArc
|
From: |
Jeff Kubascik |
|
Subject: |
Re: [PATCH] target/arm: adjust program counter for wfi exception in AArch32 |
|
Date: |
Tue, 14 Jan 2020 08:22:40 -0500 |
|
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
On 1/13/2020 9:41 PM, Richard Henderson wrote:
> On 1/10/20 8:02 AM, Jeff Kubascik wrote:
>> - env->pc -= insn_len;
>> + if (env->aarch64)
>> + env->pc -= insn_len;
>> + else
>> + env->regs[15] -= insn_len;
>
> QEMU requires all braces. See CODING_STYLE.
I received an automated email from Patchew regarding the coding style issue. I
have submitted a v2 of the patch with this correction yesterday.
> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~
>
Thanks!
Jeff Kubascik