qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/arm: adjust program counter for wfi exception in AArc


From: Richard Henderson
Subject: Re: [PATCH] target/arm: adjust program counter for wfi exception in AArch32
Date: Mon, 13 Jan 2020 16:41:34 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/10/20 8:02 AM, Jeff Kubascik wrote:
> -        env->pc -= insn_len;
> +        if (env->aarch64)
> +            env->pc -= insn_len;
> +        else
> +            env->regs[15] -= insn_len;

QEMU requires all braces.  See CODING_STYLE.

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]