Re: [PATCH 2/5] hw/arm: ast2600: Wire up the eMMC controller

[Andrew Jeffery]

On Fri, 10 Jan 2020, at 22:26, Cédric Le Goater wrote:
> >> +
> >> +    sysbus_init_child_obj(obj, "emmc", OBJECT(&s->emmc), sizeof(s->emmc),
> >> +                          TYPE_ASPEED_SDHCI);
> >> +
> >> +    object_property_set_int(OBJECT(&s->emmc), 1, "num-slots", 
> >> &error_abort);
> >> +
> >> +    sysbus_init_child_obj(obj, "emmc[*]", OBJECT(&s->emmc.slots[0]),
> > 
> > Single block, so use "emmc" instead.
> 
> Andrew, how should we call the objects in the slots ? "sdhci" ? 

I think that's the right way to go, but maybe we need to rethink the naming at 
the
controller level.

Andrew