Re: [PATCH 3/4] Makefile: Restrict system emulation and tools objects

[Thomas Huth]

On 10/01/2020 09.25, Philippe Mathieu-Daudé wrote:
> Le ven. 10 janv. 2020 09:18, Thomas Huth <address@hidden
> <mailto:address@hidden>> a écrit :
> 
>     On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote:
>     > Restrict all the system emulation and tools objects with a
>     > Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check.
>     >
>     > Using the same description over and over is not very helpful.
>     > Use it once, just before the if() block.
>     >
>     > Signed-off-by: Philippe Mathieu-Daudé <address@hidden
>     <mailto:address@hidden>>
>     > ---
>     >  Makefile.objs | 19 +++++++------------
>     >  1 file changed, 7 insertions(+), 12 deletions(-)
>     >
>     > diff --git a/Makefile.objs b/Makefile.objs
>     > index 5aae561984..395dd1e670 100644
>     > --- a/Makefile.objs
>     > +++ b/Makefile.objs
>     > @@ -4,16 +4,15 @@ stub-obj-y = stubs/
>     >  util-obj-y = crypto/ util/ qobject/ qapi/
>     >  qom-obj-y = qom/
>     > 
>     >
>     +#######################################################################
>     > +# code used by both qemu system emulation and qemu-img
>     > +
>     > +ifeq ($(call lor,$(CONFIG_SOFTMMU),$(CONFIG_TOOLS)),y)
> 
>     That ",y" at the end looks wrong?
> 
> 
> It's the result of the logical OR.

-ENOTENOUGHCOFFEEYET

Your code is fine, of course.

Reviewed-by: Thomas Huth <address@hidden>