[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] configure: Do not build libfdt is not required
From: |
Thomas Huth |
Subject: |
Re: [PATCH 1/4] configure: Do not build libfdt is not required |
Date: |
Thu, 9 Jan 2020 17:33:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote:
> We only require libfdt for system emulation, in a small set
> of architecture:
>
> 4077 # fdt support is mandatory for at least some target architectures,
> 4078 # so insist on it if we're building those system emulators.
> 4079 fdt_required=no
> 4080 for target in $target_list; do
> 4081 case $target in
> 4082
> aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu|riscv*-softmmu)
> 4083 fdt_required=yes
>
> Do not build libfdt if we did not manually specified --enable-fdt.
I suggest to add:
"... or have one of the platforms that require it in our target list."
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> configure | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configure b/configure
> index 0ce2c0354a..266a8386d1 100755
> --- a/configure
> +++ b/configure
> @@ -4092,6 +4092,8 @@ if test "$fdt_required" = "yes"; then
> "targets which need it (by specifying a cut down --target-list)."
> fi
> fdt=yes
> +elif test "$fdt" != "yes" ; then
> + fdt=no
> fi
>
> if test "$fdt" != "no" ; then
>
Reviewed-by: Thomas Huth <address@hidden>