Re: [PULL 00/38] Misc patches for 2020-01-08

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/38] Misc patches for 2020-01-08
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
142dbb5 chardev: Use QEMUChrEvent enum in IOEventHandler typedef
5707100 chardev: use QEMUChrEvent instead of int
bc9d646 chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler
f90e9bd monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler
73d932d monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler
06a6200 virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler
57a4e06 vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler
9ff0f89 vhost-user-net: Explicit we ignore few QEMUChrEvent in IOEventHandler
c10538d vhost-user-crypto: Explicit we ignore some QEMUChrEvent in 
IOEventHandler
180e591 ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler
e3984fa hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler
555f80e hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler
5ed5ef3 hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler
b66f2a8 hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler
5de243a hw/ipmi: Remove unnecessary declarations
11e5858 target/i386: Add missed features to Cooperlake CPU model
626a98d target/i386: Add new bit definitions of MSR_IA32_ARCH_CAPABILITIES
a66ab57 target/i386: Fix handling of k_gs_base register in 32-bit mode in 
gdbstub
7a1f52c hw/rtc/mc146818: Add missing dependency on ISA Bus
60ec11c hw/nvram/Kconfig: Restrict CHRP NVRAM to machines using OpenBIOS or SLOF
fd8c8c8 hw/nvram/Kconfig: Add an entry for the NMC93xx EEPROM
4c25b6d hw/ppc/Kconfig: Only select FDT helper for machines using it
f0e9de1 hw/ppc/Kconfig: Only select fw_cfg with machines using OpenBIOS
1796ba5 hw/ppc/Makefile: Simplify the sPAPR PCI objects rule
5ce107f hw/ppc/Kconfig: Let the Xilinx Virtex5 ML507 use the PPC-440 devices
ae88f4b hw/ppc/Kconfig: Let the Sam460ex board use the PowerPC 405 devices
094c2d7 hw/ppc/Kconfig: Restrict the MPC I2C controller to e500-based platforms
6cb885f hw/i386/Kconfig: Let the MicroVM machine select the SERIAL_ISA config
97f9d91 hw/intc/i8259: Fix Kconfig dependency on ISA bus
1f6f890 hw/usb/redirect: Do not link 'usb-redir' device when USB not enabled
4da324c hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus
094c726 hw/i386/pc: fix regression in parsing vga cmdline parameter
e88dd8b hw/i386/x86-iommu: Add missing stubs
0a7f7f0 replay: record and replay random number sources
3ee2d96 replay: check other timers for icount limit
0e1f61e accel/kvm: Make "kernel_irqchip" default on
8ca507a x86: Check for machine state object class before typecasting it

=== OUTPUT BEGIN ===
1/37 Checking commit 8ca507a98211 (x86: Check for machine state object class 
before typecasting it)
2/37 Checking commit 0e1f61e65a1c (accel/kvm: Make "kernel_irqchip" default on)
ERROR: line over 90 characters
#57: FILE: accel/kvm/kvm-all.c:2075:
+        s->kernel_irqchip_split = mc->default_kernel_irqchip_split ? 
ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF;

total: 1 errors, 0 warnings, 78 lines checked

Patch 2/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/37 Checking commit 3ee2d96652d6 (replay: check other timers for icount limit)
4/37 Checking commit 0a7f7f00726b (replay: record and replay random number 
sources)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 4/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/37 Checking commit e88dd8b2ac6e (hw/i386/x86-iommu: Add missing stubs)
6/37 Checking commit 094c7269d577 (hw/i386/pc: fix regression in parsing vga 
cmdline parameter)
7/37 Checking commit 4da324c41622 (hw/timer/Kconfig: Intel 8254 PIT depends of 
ISA bus)
8/37 Checking commit 1f6f8906481c (hw/usb/redirect: Do not link 'usb-redir' 
device when USB not enabled)
9/37 Checking commit 97f9d91e0c7b (hw/intc/i8259: Fix Kconfig dependency on ISA 
bus)
10/37 Checking commit 6cb885f1135c (hw/i386/Kconfig: Let the MicroVM machine 
select the SERIAL_ISA config)
11/37 Checking commit 094c2d79bae6 (hw/ppc/Kconfig: Restrict the MPC I2C 
controller to e500-based platforms)
12/37 Checking commit ae88f4bd895b (hw/ppc/Kconfig: Let the Sam460ex board use 
the PowerPC 405 devices)
13/37 Checking commit 5ce107f8e071 (hw/ppc/Kconfig: Let the Xilinx Virtex5 
ML507 use the PPC-440 devices)
14/37 Checking commit 1796ba599cfc (hw/ppc/Makefile: Simplify the sPAPR PCI 
objects rule)
15/37 Checking commit f0e9de1d2c65 (hw/ppc/Kconfig: Only select fw_cfg with 
machines using OpenBIOS)
16/37 Checking commit 4c25b6d349a2 (hw/ppc/Kconfig: Only select FDT helper for 
machines using it)
17/37 Checking commit fd8c8c800dfc (hw/nvram/Kconfig: Add an entry for the 
NMC93xx EEPROM)
18/37 Checking commit 60ec11cd6968 (hw/nvram/Kconfig: Restrict CHRP NVRAM to 
machines using OpenBIOS or SLOF)
19/37 Checking commit 7a1f52c6713e (hw/rtc/mc146818: Add missing dependency on 
ISA Bus)
20/37 Checking commit a66ab57baec2 (target/i386: Fix handling of k_gs_base 
register in 32-bit mode in gdbstub)
21/37 Checking commit 626a98dde84e (target/i386: Add new bit definitions of 
MSR_IA32_ARCH_CAPABILITIES)
22/37 Checking commit 11e5858ce379 (target/i386: Add missed features to 
Cooperlake CPU model)
WARNING: line over 80 characters
#34: FILE: target/i386/cpu.c:3217:
+        /* Missing: Mode-based execute control (XS/XU), processor tracing, TSC 
scaling */

WARNING: line over 80 characters
#38: FILE: target/i386/cpu.c:3221:
+             VMX_VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL | 
VMX_VM_ENTRY_LOAD_IA32_PAT |

WARNING: line over 80 characters
#43: FILE: target/i386/cpu.c:3226:
+             MSR_VMX_EPT_INVEPT_SINGLE_CONTEXT | 
MSR_VMX_EPT_INVEPT_ALL_CONTEXT |

WARNING: line over 80 characters
#45: FILE: target/i386/cpu.c:3228:
+             MSR_VMX_EPT_INVVPID_SINGLE_CONTEXT | 
MSR_VMX_EPT_INVVPID_ALL_CONTEXT |

WARNING: line over 80 characters
#58: FILE: target/i386/cpu.c:3241:
+        .features[FEAT_VMX_PROCBASED_CTLS] = 
VMX_CPU_BASED_VIRTUAL_INTR_PENDING |

WARNING: line over 80 characters
#75: FILE: target/i386/cpu.c:3258:
+             VMX_SECONDARY_EXEC_ENABLE_VPID | 
VMX_SECONDARY_EXEC_UNRESTRICTED_GUEST |

WARNING: line over 80 characters
#78: FILE: target/i386/cpu.c:3261:
+             VMX_SECONDARY_EXEC_RDRAND_EXITING | 
VMX_SECONDARY_EXEC_ENABLE_INVPCID |

total: 0 errors, 7 warnings, 63 lines checked

Patch 22/37 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/37 Checking commit 5de243a14b2d (hw/ipmi: Remove unnecessary declarations)
24/37 Checking commit b66f2a82b4fd (hw/ipmi: Explicit we ignore some 
QEMUChrEvent in IOEventHandler)
25/37 Checking commit 5ed5ef32b15b (hw/char/terminal3270: Explicit ignored 
QEMUChrEvent in IOEventHandler)
26/37 Checking commit 555f80e20e9c (hw/usb/dev-serial: Explicit we ignore few 
QEMUChrEvent in IOEventHandler)
27/37 Checking commit e3984fa94f32 (hw/usb/redirect: Explicit we ignore few 
QEMUChrEvent in IOEventHandler)
28/37 Checking commit 180e59121b4f (ccid-card-passthru: Explicit we ignore 
QEMUChrEvent in IOEventHandler)
29/37 Checking commit c10538d40b6a (vhost-user-crypto: Explicit we ignore some 
QEMUChrEvent in IOEventHandler)
30/37 Checking commit 9ff0f8931390 (vhost-user-net: Explicit we ignore few 
QEMUChrEvent in IOEventHandler)
31/37 Checking commit 57a4e060308e (vhost-user-blk: Explicit we ignore few 
QEMUChrEvent in IOEventHandler)
32/37 Checking commit 06a62008585f (virtio-console: Explicit we ignore some 
QEMUChrEvent in IOEventHandler)
33/37 Checking commit 73d932de962e (monitor/qmp: Explicit we ignore few 
QEMUChrEvent in IOEventHandler)
34/37 Checking commit f90e9bd1e01b (monitor/hmp: Explicit we ignore a 
QEMUChrEvent in IOEventHandler)
35/37 Checking commit bc9d646e5795 (chardev/char: Explicit we ignore some 
QEMUChrEvent in IOEventHandler)
36/37 Checking commit 5707100af113 (chardev: use QEMUChrEvent instead of int)
37/37 Checking commit 142dbb520e8b (chardev: Use QEMUChrEvent enum in 
IOEventHandler typedef)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden