[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 33/38] virtio-console: Explicit we ignore some QEMUChrEvent in IOE
From: |
Paolo Bonzini |
Subject: |
[PULL 33/38] virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler |
Date: |
Wed, 8 Jan 2020 13:32:50 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit all the events ignored by this frontend, to silent the
following GCC warning:
CC hw/char/virtio-console.o
hw/char/virtio-console.c: In function ‘chr_event’:
hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_BREAK’
not handled in switch [-Werror=switch]
154 | switch (event) {
| ^~~~~~
hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_IN’
not handled in switch [-Werror=switch]
hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’
not handled in switch [-Werror=switch]
cc1: all warnings being treated as errors
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/char/virtio-console.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c
index c13649f..cbb304d 100644
--- a/hw/char/virtio-console.c
+++ b/hw/char/virtio-console.c
@@ -162,6 +162,11 @@ static void chr_event(void *opaque, int event)
}
virtio_serial_close(port);
break;
+ case CHR_EVENT_BREAK:
+ case CHR_EVENT_MUX_IN:
+ case CHR_EVENT_MUX_OUT:
+ /* Ignore */
+ break;
}
}
--
1.8.3.1
- [PULL 25/38] hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler, (continued)
- [PULL 25/38] hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 24/38] hw/ipmi: Remove unnecessary declarations, Paolo Bonzini, 2020/01/08
- [PULL 26/38] hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 27/38] hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 28/38] hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 29/38] ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 30/38] vhost-user-crypto: Explicit we ignore some QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 31/38] vhost-user-net: Explicit we ignore few QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 32/38] vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 34/38] monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 33/38] virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler,
Paolo Bonzini <=
- [PULL 37/38] chardev: use QEMUChrEvent instead of int, Paolo Bonzini, 2020/01/08
- [PULL 35/38] monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 36/38] chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler, Paolo Bonzini, 2020/01/08
- [PULL 38/38] chardev: Use QEMUChrEvent enum in IOEventHandler typedef, Paolo Bonzini, 2020/01/08
- Re: [PULL 00/38] Misc patches for 2020-01-08, no-reply, 2020/01/08
- Re: [PULL 00/38] Misc patches for 2020-01-08, Peter Maydell, 2020/01/13