Re: [PATCH v2 6/8] x86: move more x86-generic functions out of PC files

[Paolo Bonzini]

Yes, I am preparing a pull request now.

Paolo

Il mer 8 gen 2020, 09:04 Gerd Hoffmann <address@hidden> ha scritto:

On Thu, Dec 12, 2019 at 06:29:12PM +0100, Paolo Bonzini wrote:
> These are needed by microvm too, so move them outside of PC-specific files.
> With this patch, microvm.c need not include pc.h anymore.
>
> Signed-off-by: Paolo Bonzini <address@hidden>

Current master does not work with libvirt ...

$ virsh start fedora-org-base
error: Failed to start domain fedora-org-base
error: internal error: Failed to probe QEMU binary with QMP: /home/kraxel/projects/qemu/target/i386/kvm.c:2176:kvm_arch_init: Object 0x5608f33be1f0 is not an instance of type x86-machine

... and git bisect lands at this patch.

cheers,
  Gerd