qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 00/29] cputlb: Remove support for MMU_MODE*_SUFFIX


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 00/29] cputlb: Remove support for MMU_MODE*_SUFFIX
Date: Sat, 4 Jan 2020 15:40:33 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/29/19 12:10 AM, Richard Henderson wrote:
This is part of a project to raise the limit on NB_MMU_MODES.

One of those is in cpu_ldst.h, in support of MMU_MODE*_SUFFIX.
While this could be extended, it's not the best interface for
such things.  Better is a single interface that allows a variable
mmu_idx.  The best exemplars of that is the usage in target/mips
and target/ppc.

In the process, I tried to clean up the implementation of these
functions for softmmu and user-only.

Aleksander asked about code size changes.  They vary between
a minor size increase (e.g. for qemu-system-alpha, where there
are in fact no uses of the functions, which are now present as
out-of-line functions rather than eliminated inline functions),
to a minor size decrease (e.g. -79k/-1.6% for qemu-system-i386).
See below for details.

Changes for v3:
   * Add patch to avoid breaking build for --enable-plugins.
   * Rebase on master and resolve conflicts.

Changes for v2:
   * Significantly revised docs/devel/loads-stores.rst.
   * m68k and s390x dropped #defines and use *_mmuidx_ra directly.

Patches lacking review:
0009-plugins-Include-trace-mem.h-in-api.c.patch
0010-cputlb-Move-body-of-cpu_ldst_template.h-out-of-li.patch


r~


Cc: Aleksandar Markovic <address@hidden>
Cc: Aleksandar Rikalo <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Chris Wulff <address@hidden>
Cc: David Gibson <address@hidden>
Cc: David Hildenbrand <address@hidden>
Cc: Edgar E. Iglesias <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Cc: Guan Xuetao <address@hidden>
Cc: Laurent Vivier <address@hidden>
Cc: Marek Vasut <address@hidden>
Cc: Max Filippov <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Peter Maydell <address@hidden>

Richard Henderson (29):
   target/xtensa: Use probe_access for itlb_hit_test
   cputlb: Use trace_mem_get_info instead of trace_mem_build_info
   trace: Remove trace_mem_build_info_no_se_[bl]e
   target/s390x: Include tcg.h in mem_helper.c
   target/arm: Include tcg.h in sve_helper.c
   accel/tcg: Include tcg.h in tcg-runtime.c
   linux-user: Include tcg.h in syscall.c
   linux-user: Include trace-root.h in syscall-trace.h
   plugins: Include trace/mem.h in api.c
   cputlb: Move body of cpu_ldst_template.h out of line
   translator: Use cpu_ld*_code instead of open-coding
   cputlb: Rename helper_ret_ld*_cmmu to cpu_ld*_code
   cputlb: Provide cpu_(ld,st}*_mmuidx_ra for user-only
   target/i386: Use cpu_*_mmuidx_ra instead of templates
   cputlb: Expand cpu_ldst_useronly_template.h in user-exec.c
   target/nios2: Remove MMU_MODE{0,1}_SUFFIX
   target/alpha: Remove MMU_MODE{0,1}_SUFFIX
   target/cris: Remove MMU_MODE{0,1}_SUFFIX
   target/i386: Remove MMU_MODE{0,1,2}_SUFFIX
   target/microblaze: Remove MMU_MODE{0,1,2}_SUFFIX
   target/sh4: Remove MMU_MODE{0,1}_SUFFIX
   target/unicore32: Remove MMU_MODE{0,1}_SUFFIX
   target/xtensa: Remove MMU_MODE{0,1,2,3}_SUFFIX
   target/m68k: Use cpu_*_mmuidx_ra instead of MMU_MODE{0,1}_SUFFIX
   target/mips: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX
   target/s390x: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX
   target/ppc: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX
   cputlb: Remove support for MMU_MODE*_SUFFIX
   cputlb: Expand cpu_ldst_template.h in cputlb.c

Series:
Tested-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]