Re: [PATCH v3 09/29] plugins: Include trace/mem.h in api.c

[Philippe Mathieu-Daudé]

On 1/3/20 10:59 PM, Richard Henderson wrote:
> On 1/3/20 5:22 PM, Philippe Mathieu-Daudé wrote:
> > Hi Richard,
> >
> > On 12/29/19 12:11 AM, Richard Henderson wrote:
> > > Code movement in an upcoming patch will show that this file
> > > was implicitly depending on trace/mem.h being included beforehand.
> >
> > Ah, it uses the TRACE_MEM_* macros from "trace/mem-internal.h", which is
> > include by "trace/mem.h". OK.
> >
> > Which part requires "trace-root.h"? Isn't it "trace/mem-internal.h" that should
> > include "trace-root.h"?
>
> I don't know -- perhaps it's not required at all.  I think I did a blind copy
> of the trace related includes that were being removed.

I'v tested your series, removing "trace-root.h" from this patch and 
building next patches, and there is no problem, it is indeed not 
required at all.

Removing "trace-root.h":
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Regardless:
Tested-by: Philippe Mathieu-Daudé <address@hidden>