[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/25] qapi: Improve reporting of invalid name errors
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 09/25] qapi: Improve reporting of invalid name errors |
|
Date: |
Tue, 24 Sep 2019 10:48:04 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/24/19 8:28 AM, Markus Armbruster wrote:
> Split check_name() into check_name_is_str() and check_name_str(), keep
> check_name() as a wrapper.
>
> Move add_name()'s call into its caller check_exprs(), and inline.
>
> This permits delaying check_name_str() there, so its error message
> gains an "in definition" line.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 19/25] qapi: Improve reporting of invalid flags, (continued)
- [PATCH 20/25] qapi: Improve reporting of missing / unknown definition keys, Markus Armbruster, 2019/09/24
- [PATCH 05/25] qapi: Clean up member name case checking, Markus Armbruster, 2019/09/24
- [PATCH 23/25] qapi: Improve reporting of missing documentation comment, Markus Armbruster, 2019/09/24
- [PATCH 09/25] qapi: Improve reporting of invalid name errors, Markus Armbruster, 2019/09/24
- Re: [PATCH 09/25] qapi: Improve reporting of invalid name errors,
Eric Blake <=
- [PATCH 25/25] qapi: Improve source file read error handling, Markus Armbruster, 2019/09/24
- [PATCH 08/25] qapi: Reorder check_FOO() parameters for consistency, Markus Armbruster, 2019/09/24
- [PATCH 14/25] qapi: Plumb info to the QAPISchemaMember, Markus Armbruster, 2019/09/24
- [PATCH 04/25] qapi: Prefix frontend errors with an "in definition" line, Markus Armbruster, 2019/09/24
- [PATCH 21/25] qapi: Avoid redundant definition references in error messages, Markus Armbruster, 2019/09/24