Re: [PATCH 08/25] qapi: Reorder check_FOO() parameters for consistency

[Eric Blake]

On 9/24/19 8:28 AM, Markus Armbruster wrote:
> Most check_FOO() take the thing being checked as first argument.
> check_name(), check_type(), check_known_keys() don't.  Clean that up.
> 
> While there, drop a "Todo" comment that should have been dropped in
> commit 87adbbffd4 "qapi: add a dictionary form for TYPE".
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi/common.py | 80 ++++++++++++++++++++----------------------
>  1 file changed, 39 insertions(+), 41 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature