[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tests/migration: Fail on unexpected migration states
From: |
Juan Quintela |
Subject: |
Re: [PATCH 1/2] tests/migration: Fail on unexpected migration states |
Date: |
Tue, 24 Sep 2019 09:24:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> We've got various places where we wait for a migration to enter
> a given state; but if we enter an unexpected state we tend to fail
> in odd ways; add a mechanism for explicitly testing for any state
> which we shouldn't be in.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
> - wait_for_migration_status(from, "postcopy-active");
> + wait_for_migration_status(from, "postcopy-active",
> + (const char * []) { "failed",
> + "completed", NULL });
>
I really preffer not to use that kind of casts.
const char *ungoals[] = { "failed", "completed", NULL };
but as it is you who are doing the patches, I will not complain O:-)