Re: [PATCH 0/2] migration test tweeks

[Dr. David Alan Gilbert]

* Peter Xu (address@hidden) wrote:
> On Mon, Sep 23, 2019 at 02:10:20PM +0100, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > Alex noticed that some of the postcopy tests would occasionally
> > hang; this series adds some checks to make them more likely
> > to assert than hang in some failure cases, and changes
> > the migration bandwidth so that under load it's much more likely
> > to manage to land in postcopy.
> > 
> > Dr. David Alan Gilbert (2):
> >   tests/migration: Fail on unexpected migration states
> >   tests/migration/postcopy: trim migration bandwidth
> 
> Reviewed-by: Peter Xu <address@hidden>
> 
> I might be even more aggresive on patch 2 when turning down the
> bandwidth. :)
> 
> Another thing I thought about on the hang issue is that maybe we can
> give a timeout for the waits and when the timeout triggers before a
> directly assert in the test case we send sigabrt to QEMU (just like
> what kill_qemu does) then we could have a chance to see the cores.
> Not sure whether that could help, though.

Yes I might need to add that; I can see there's another hang somewhere
even with these two patches.
(I *think* it's at the end while it's waiting for completion after
resumption - but I've not figured out what's going on yet).

Dave

> Regards,
> 
> -- 
> Peter Xu
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK