Re: [PATCH] roms: Add a 'make help' target alias

[John Snow]

On 9/20/19 1:11 PM, Philippe Mathieu-Daudé wrote:
> Various C projects provide a 'make help' target. Our root directory
> does so. The roms/ directory lacks a such rule, but already displays
> a help output when the default target is called.
> Add a 'help' target aliased to the default one, to avoid:
> 
>   $ make -C roms help
>   make: *** No rule to make target 'help'.  Stop.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  roms/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/roms/Makefile b/roms/Makefile
> index 6cf07d3b44..3ffd13cc7e 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
>  #
>  EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
>  
> -default:
> +default help:
>       @echo "nothing is build by default"
>       @echo "available build targets:"
>       @echo "  bios               -- update bios.bin (seabios)"
> 

Reviewed-by: John Snow <address@hidden>

The typo can be fixed with a trivial patch or squashed into this fix,
the purity of such things doesn't matter to me.

--js