Re: [PATCH 3/3] docker: remove unused debian-sid and debian-ports

[John Snow]

On 9/20/19 12:28 PM, Philippe Mathieu-Daudé wrote:
> On 9/20/19 6:23 PM, Philippe Mathieu-Daudé wrote:
>> On 9/20/19 6:20 PM, Alex Bennée wrote:
>>> John Snow <address@hidden> writes:
>>>> On 9/20/19 4:49 AM, Philippe Mathieu-Daudé wrote:
>>>>> On 9/20/19 2:14 AM, John Snow wrote:
>>>>>> These are listed as "partial" images, but have no user.
>>>>>> Remove them.
>>>>>
>>>>> Well, I have WiP users from them. I could restore this content when they
>>>>> are ready... Ports is the base of deprecated Debian archs. On the other
>>>>> side Sid is the base for edge development I use from time to time to
>>>>> test latest gcc/binutils.
>>>>> I'll try to find time to raise WiP branches to PoC.
>>>>>
>>>>
>>>> I think that's the right thing to do. Right now, the docker tests
>>>> directory has a lot of stale entries and unusable tests. That might be
>>>> fine for the people working on it, but it makes it hard to understand
>>>> and use for those of us who only occasionally traipse into the directory.
>>>>
>>>> I'm removing all references to python2 -- but if there's no way for me
>>>> to test debian-sid and debian-ports, I can't test changes I need to make
>>>> to these "partial images", so they should be removed until they are
>>>> consumable.
>>>>
>>>> While I am sympathetic to the idea of having a library of partial images
>>>> to use for future tests, they're prone to rot if there's no way to
>>>> exercise them in-tree.
>>>
>>> Don't forget some "partial" images are only used for building TCG tests
>>> - we want to keep them. But as git is forever I can drop the sid/ports
>>> stuff for now until Phillipe has something to use them again.
>>
>> For Sid I have this case:
>>
>> -- >8 --
>> #
>> # Docker Renesas RX cross-compiler target
>> #
>> # This docker target builds on the debian Sid base image.
>> #
>> # Copyright (c) 2019 Philippe Mathieu-Daudé
>> #
>> # SPDX-License-Identifier: GPL-2.0-or-later
>> #
>> FROM qemu:debian-sid
> 
> Oh well nevermind it is old, so it probably now works with debian-10.
> 
> I used the Ports base for sparc32 and x32, I don't have them on my
> workstation I'll check during the WE.
> 

If you want to keep docker-sid as a partial image for possible future
uses, you might consider adding a simple amd64 user -- debian-sid-amd64
would suffice.

It doesn't have to do anything interesting, but it exists to give
debian-sid a user.

I'd rather not waste your hard work, but I am making a plea that any
images defined in the tree can be tested by running tests that use them.

--js