[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/34] s390x/tcg: MVC: Use is_destructive_overlap()
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 06/34] s390x/tcg: MVC: Use is_destructive_overlap() |
Date: |
Thu, 19 Sep 2019 14:40:47 +0200 |
From: David Hildenbrand <address@hidden>
Let's use the new helper, that also detects destructive overlaps when
wrapping.
We'll make the remaining code (e.g., fast_memmove()) aware of wrapping
later.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 013e8d6045e7..c31cf4959358 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -330,7 +330,7 @@ static uint32_t do_helper_mvc(CPUS390XState *env, uint32_t
l, uint64_t dest,
*/
if (dest == src + 1) {
fast_memset(env, dest, cpu_ldub_data_ra(env, src, ra), l, ra);
- } else if (dest < src || src + l <= dest) {
+ } else if (!is_destructive_overlap(env, dest, src, l)) {
fast_memmove(env, dest, src, l, ra);
} else {
for (i = 0; i < l; i++) {
--
2.20.1
- [Qemu-devel] [PULL 15/34] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, (continued)
- [Qemu-devel] [PULL 15/34] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 14/34] s390x/tcg: MVST: Fix storing back the addresses to registers, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 19/34] s390x/tcg: MVC: Fault-safe handling on destructive overlaps, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 08/34] s390x/tcg: MVPG: Properly wrap the addresses, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 12/34] s390x/tcg: MVCS/MVCP: Properly wrap the length, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 09/34] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 05/34] s390x/tcg: MVC: Increment the length once, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 13/34] s390x/tcg: MVST: Check for specification exceptions, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 11/34] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 07/34] s390x/tcg: MVPG: Check for specification exceptions, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 06/34] s390x/tcg: MVC: Use is_destructive_overlap(),
Cornelia Huck <=
- [Qemu-devel] [PULL 04/34] s390x/tcg: MVCL: Process max 4k bytes at a time, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 03/34] s390x/tcg: MVCL: Detect destructive overlaps, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 02/34] s390x/tcg: MVCL: Zero out unused bits of address, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 01/34] s390x/tcg: Reset exception_index to -1 instead of 0, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 10/34] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, Cornelia Huck, 2019/09/19
- Re: [PULL 00/34] s390x update, Peter Maydell, 2019/09/20