[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/34] s390x/tcg: MVPG: Check for specification excep
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 07/34] s390x/tcg: MVPG: Check for specification exceptions |
Date: |
Thu, 19 Sep 2019 14:40:48 +0200 |
From: David Hildenbrand <address@hidden>
Perform the checks documented in the PoP.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index c31cf4959358..7dfa848744a6 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -672,6 +672,13 @@ uint64_t HELPER(clst)(CPUS390XState *env, uint64_t c,
uint64_t s1, uint64_t s2)
/* move page */
uint32_t HELPER(mvpg)(CPUS390XState *env, uint64_t r0, uint64_t r1, uint64_t
r2)
{
+ const bool f = extract64(r0, 11, 1);
+ const bool s = extract64(r0, 10, 1);
+
+ if ((f && s) || extract64(r0, 12, 4)) {
+ s390_program_interrupt(env, PGM_SPECIFICATION, ILEN_AUTO, GETPC());
+ }
+
/* ??? missing r0 handling, which includes access keys, but more
importantly optional suppression of the exception! */
fast_memmove(env, r1, r2, TARGET_PAGE_SIZE, GETPC());
--
2.20.1
- [Qemu-devel] [PULL 16/34] s390x/tcg: Fault-safe memset, (continued)
- [Qemu-devel] [PULL 16/34] s390x/tcg: Fault-safe memset, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 15/34] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 14/34] s390x/tcg: MVST: Fix storing back the addresses to registers, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 19/34] s390x/tcg: MVC: Fault-safe handling on destructive overlaps, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 08/34] s390x/tcg: MVPG: Properly wrap the addresses, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 12/34] s390x/tcg: MVCS/MVCP: Properly wrap the length, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 09/34] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 05/34] s390x/tcg: MVC: Increment the length once, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 13/34] s390x/tcg: MVST: Check for specification exceptions, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 11/34] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 07/34] s390x/tcg: MVPG: Check for specification exceptions,
Cornelia Huck <=
- [Qemu-devel] [PULL 06/34] s390x/tcg: MVC: Use is_destructive_overlap(), Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 04/34] s390x/tcg: MVCL: Process max 4k bytes at a time, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 03/34] s390x/tcg: MVCL: Detect destructive overlaps, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 02/34] s390x/tcg: MVCL: Zero out unused bits of address, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 01/34] s390x/tcg: Reset exception_index to -1 instead of 0, Cornelia Huck, 2019/09/19
- [Qemu-devel] [PULL 10/34] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, Cornelia Huck, 2019/09/19
- Re: [PULL 00/34] s390x update, Peter Maydell, 2019/09/20