[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb |
|
Date: |
Wed, 18 Sep 2019 10:13:01 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 18/09/19 07:26, Richard Henderson wrote:
> RFC because this doesn't work, and I don't quite understand why.
> The only failing test is {i386,x86_64} pxe-test -- the other
> migration tests that use notdirty all pass.
>
> Note that if you try to reproduce this on x86, you'll likely
> have to --disable-kvm, as otherwise the pxe-test will skip tcg.
>
> Anyone who knows how this works willing to have a look?
I think patch 2 is doing too much. Why don't you keep
memory_notdirty_write_prepare and memory_notdirty_write_complete at
first (so that the atomic path is completely unchanged wrt MMU lookup),
and then simplify that separately? Maybe that shows what's going on.
Paolo