[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/17] vfio: Pass local error object pointer to erro
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PATCH 06/17] vfio: Pass local error object pointer to error_append_hint() |
Date: |
Tue, 17 Sep 2019 12:21:08 +0200 |
User-agent: |
StGit/unknown-version |
Ensure that hints are added even if errp is &error_fatal or &error_abort.
Signed-off-by: Greg Kurz <address@hidden>
---
hw/vfio/common.c | 14 ++++++++++----
hw/vfio/pci.c | 12 ++++++++----
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 3e03c495d868..05b1c39a426f 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -1469,10 +1469,13 @@ VFIOGroup *vfio_get_group(int groupid, AddressSpace
*as, Error **errp)
}
if (!(status.flags & VFIO_GROUP_FLAGS_VIABLE)) {
- error_setg(errp, "group %d is not viable", groupid);
- error_append_hint(errp,
+ Error *err = NULL;
+
+ error_setg(&err, "group %d is not viable", groupid);
+ error_append_hint(&err,
"Please ensure all devices within the iommu_group "
"are bound to their vfio bus driver.\n");
+ error_propagate(errp, err);
goto close_fd_exit;
}
@@ -1531,11 +1534,14 @@ int vfio_get_device(VFIOGroup *group, const char *name,
fd = ioctl(group->fd, VFIO_GROUP_GET_DEVICE_FD, name);
if (fd < 0) {
- error_setg_errno(errp, errno, "error getting device from group %d",
+ Error *err = NULL;
+
+ error_setg_errno(&err, errno, "error getting device from group %d",
group->groupid);
- error_append_hint(errp,
+ error_append_hint(&err,
"Verify all devices in group %d are bound to vfio-<bus> "
"or pci-stub and not already in use\n", group->groupid);
+ error_propagate(errp, err);
return fd;
}
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index dc3479c374e3..b037dec2215b 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -2527,10 +2527,13 @@ static void vfio_populate_device(VFIOPCIDevice *vdev,
Error **errp)
g_free(reg_info);
if (vdev->features & VFIO_FEATURE_ENABLE_VGA) {
- ret = vfio_populate_vga(vdev, errp);
+ Error *err = NULL;
+
+ ret = vfio_populate_vga(vdev, &err);
if (ret) {
- error_append_hint(errp, "device does not support "
+ error_append_hint(&err, "device does not support "
"requested feature x-vga\n");
+ error_propagate(errp, err);
return;
}
}
@@ -2714,9 +2717,10 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
if (!vdev->vbasedev.sysfsdev) {
if (!(~vdev->host.domain || ~vdev->host.bus ||
~vdev->host.slot || ~vdev->host.function)) {
- error_setg(errp, "No provided host device");
- error_append_hint(errp, "Use -device vfio-pci,host=DDDD:BB:DD.F "
+ error_setg(&err, "No provided host device");
+ error_append_hint(&err, "Use -device vfio-pci,host=DDDD:BB:DD.F "
"or -device vfio-pci,sysfsdev=PATH_TO_DEVICE\n");
+ error_propagate(errp, err);
return;
}
vdev->vbasedev.sysfsdev =
- Re: [Qemu-devel] [PATCH 01/17] error: Update error_append_hint()'s documentation, (continued)
- [Qemu-devel] [PATCH 03/17] char/spice: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 04/17] ppc: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 05/17] arm: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 06/17] vfio: Pass local error object pointer to error_append_hint(),
Greg Kurz <=
- [Qemu-devel] [PATCH 07/17] virtio-pci: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 08/17] pcie_root_port: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 09/17] hw/rdma: Fix missing conversion to rdma_error_report(), Greg Kurz, 2019/09/17
- [Qemu-devel] [PATCH 10/17] s390x/css: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17