[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/17] char/spice: Pass local error object pointer t
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PATCH 03/17] char/spice: Pass local error object pointer to error_append_hint() |
Date: |
Tue, 17 Sep 2019 12:20:49 +0200 |
User-agent: |
StGit/unknown-version |
Ensure that hints are added even if errp is &error_fatal or &error_abort.
Signed-off-by: Greg Kurz <address@hidden>
---
chardev/spice.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/chardev/spice.c b/chardev/spice.c
index 241e2b7770eb..ed5996467c32 100644
--- a/chardev/spice.c
+++ b/chardev/spice.c
@@ -279,10 +279,12 @@ static void qemu_chr_open_spice_vmc(Chardev *chr,
if (*psubtype == NULL) {
char *subtypes = g_strjoinv(", ",
(gchar **)spice_server_char_device_recognized_subtypes());
+ Error *local_err = NULL;
- error_setg(errp, "unsupported type name: %s", type);
- error_append_hint(errp, "allowed spice char type names: %s\n",
+ error_setg(&local_err, "unsupported type name: %s", type);
+ error_append_hint(&local_err, "allowed spice char type names: %s\n",
subtypes);
+ error_propagate(errp, local_err);
g_free(subtypes);
return;
- Re: [Qemu-devel] [PATCH 01/17] error: Update error_append_hint()'s documentation, (continued)
[Qemu-devel] [PATCH 03/17] char/spice: Pass local error object pointer to error_append_hint(),
Greg Kurz <=
[Qemu-devel] [PATCH 04/17] ppc: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
[Qemu-devel] [PATCH 05/17] arm: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
[Qemu-devel] [PATCH 06/17] vfio: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
[Qemu-devel] [PATCH 07/17] virtio-pci: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
[Qemu-devel] [PATCH 08/17] pcie_root_port: Pass local error object pointer to error_append_hint(), Greg Kurz, 2019/09/17
[Qemu-devel] [PATCH 09/17] hw/rdma: Fix missing conversion to rdma_error_report(), Greg Kurz, 2019/09/17