[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHY
|
From: |
Wei Yang |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc() |
|
Date: |
Mon, 16 Sep 2019 10:02:28 +0800 |
|
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Fri, Sep 13, 2019 at 11:12:05AM +0200, Paolo Bonzini wrote:
>On 13/09/19 01:02, Wei Yang wrote:
>> It shows PHYS_MAP_NODE_NIL may represents more node the tree could hold.
>
>Which is good, it means the assert can trigger.
>
Per my understanding, it means the assert can't trigger.
>> The assert here is not harmful, while maybe we can have a better way to
>> handle
>> it?
>
>I don't know... The assert just says "careful, someone treats
>PHYS_MAP_NODE_NIL specially!". It's documentation too.
>
>Paolo
--
Wei Yang
Help you, Help me