[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHY
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc() |
|
Date: |
Fri, 13 Sep 2019 11:12:05 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 13/09/19 01:02, Wei Yang wrote:
> It shows PHYS_MAP_NODE_NIL may represents more node the tree could hold.
Which is good, it means the assert can trigger.
> The assert here is not harmful, while maybe we can have a better way to handle
> it?
I don't know... The assert just says "careful, someone treats
PHYS_MAP_NODE_NIL specially!". It's documentation too.
Paolo