[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KI
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS |
Date: |
Mon, 9 Sep 2019 09:48:31 -0400 |
On Mon, Sep 09, 2019 at 03:05:08PM +0200, Johannes Berg wrote:
> On Mon, 2019-09-09 at 08:41 -0400, Michael S. Tsirkin wrote:
>
> > > The only thing we could do is crash if it wants to use this feature
> > > without the others, but would that really be helpful?
> >
> > We can return failure from SET_PROTOCOL_FEATURES.
> > We can also fail all following messages.
>
> Only if we have F_REPLY_ACK, I think?
>
> I suppose we could fail a later command that already needs a reply
> without REPLY_ACK, but that seems difficult to debug?
Next command is GET_FEATURES. Return an error response from that
and device init will fail.
> Anyway, if you feel that we should have this as some sort of safeguard I
> can try to do that; to me it feels rather pointless as libvhost-user is
> more of a sample implementation than anything else.
Exactly for this reason :)
> Unless you also wanted to write into the spec that F_KICK_CALL_MSGS
> absolutely *requires* F_REPLY_ACK,
yep
> and add some text that tells a device
> how to behave when F_KICK_CALL_MSGS is negotiated without F_REPLY_ACK?
>
> johannes
We can document how to behave in case of inconsistent protocol features,
yes.
- Re: [Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages, (continued)
- [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/06
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Michael S. Tsirkin, 2019/09/06
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/06
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Michael S. Tsirkin, 2019/09/06
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/06
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Michael S. Tsirkin, 2019/09/08
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/09
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Michael S. Tsirkin, 2019/09/09
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/09
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/09
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Michael S. Tsirkin, 2019/09/09
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/09
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/09
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Michael S. Tsirkin, 2019/09/09
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/09
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/10
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Michael S. Tsirkin, 2019/09/11
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Johannes Berg, 2019/09/11
- Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS, Michael S. Tsirkin, 2019/09/11