[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v10 01/14] block/backup: fix backup_cow_with_offload
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH v10 01/14] block/backup: fix backup_cow_with_offload for last cluster |
Date: |
Fri, 30 Aug 2019 19:12:15 +0300 |
We shouldn't try to copy bytes beyond EOF. Fix it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/backup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/backup.c b/block/backup.c
index 2baf7bed65..16ca9a3944 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -161,7 +161,7 @@ static int coroutine_fn
backup_cow_with_offload(BackupBlockJob *job,
assert(QEMU_IS_ALIGNED(job->copy_range_size, job->cluster_size));
assert(QEMU_IS_ALIGNED(start, job->cluster_size));
- nbytes = MIN(job->copy_range_size, end - start);
+ nbytes = MIN(job->copy_range_size, MIN(end, job->len) - start);
nr_clusters = DIV_ROUND_UP(nbytes, job->cluster_size);
bdrv_reset_dirty_bitmap(job->copy_bitmap, start,
job->cluster_size * nr_clusters);
--
2.18.0
- [Qemu-devel] [PATCH v10 00/14] backup-top filter driver for backup, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 07/14] block: teach bdrv_debug_breakpoint skip filters with backing, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 03/14] block/backup: improve comment about image fleecing, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 12/14] block: add lock/unlock range functions, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 01/14] block/backup: fix backup_cow_with_offload for last cluster,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH v10 06/14] block: move block_copy from block/backup.c to separate file, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 02/14] block/backup: split shareable copying part from backup_do_cow, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 09/14] iotests: 257: drop unused Drive.device field, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 10/14] iotests: 257: drop device_add, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 11/14] block/io: refactor wait_serialising_requests, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 05/14] block/backup: fix block-comment style, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 14/14] block/backup: use backup-top instead of write notifiers, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 13/14] block: introduce backup-top filter driver, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 08/14] iotests: prepare 124 and 257 bitmap querying for backup-top filter, Vladimir Sementsov-Ogievskiy, 2019/08/30