[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v10 00/14] backup-top filter driver for backup
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH v10 00/14] backup-top filter driver for backup |
Date: |
Fri, 30 Aug 2019 19:12:14 +0300 |
Hi all!
These series introduce backup-top driver. It's a filter-node, which
do copy-before-write operation. Mirror uses filter-node for handling
guest writes, let's move to filter-node (from write-notifiers) for
backup too.
v10 (mostly by Max's comments):
01: - s/MIN(end - start, job->len - start)/MIN(end, job->len) - start
- Max's r-b
02: s/offset/start/ and drop extra variable from backup_do_copy
03: new
04: - add job->source_bs
- use two progress callbacks instead of one combined
- add comment to skip_unallocated
- drop zeroing blk's in block_copy_state_free
- s/g_new0/g_new/ before compound literal
- add comment and assertion about aio context for block-copy source and
target
- in backup_clean handle possibly executing in parallel backup_drain and
check
only s->bcs pointer in backup_drain
- fix s/job/bcs in trace-events file
05: partly new, now only fix comments style
06: a lot of changes as rebased on above changes, but it's still a clean
code move, keep Max's r-b
07: add Max's r-b
08: deeper refactoring of tests
09-11: add Max's r-b
[also, fix my email in 11]
12: - drop bdrv_refresh_filename(bs->backing->bs) call
- drop assertion of taken permission
- active = false + refresh_perms in _drop() instead of _set_perm()
13: - add comment about WRITE perm sharing
- add backup_top bs to job state
- fix cleanup on failure path in backup_job_create
- keep "fail:" path in block_copy_with_bounce_buffer
- in 56, collide on job-id instead of posix locks
Vladimir Sementsov-Ogievskiy (14):
block/backup: fix backup_cow_with_offload for last cluster
block/backup: split shareable copying part from backup_do_cow
block/backup: improve comment about image fleecing
block/backup: introduce BlockCopyState
block/backup: fix block-comment style
block: move block_copy from block/backup.c to separate file
block: teach bdrv_debug_breakpoint skip filters with backing
iotests: prepare 124 and 257 bitmap querying for backup-top filter
iotests: 257: drop unused Drive.device field
iotests: 257: drop device_add
block/io: refactor wait_serialising_requests
block: add lock/unlock range functions
block: introduce backup-top filter driver
block/backup: use backup-top instead of write notifiers
qapi/block-core.json | 8 +-
block/backup-top.h | 37 ++
include/block/block-copy.h | 75 ++++
include/block/block_int.h | 5 +
block.c | 34 +-
block/backup-top.c | 240 ++++++++++++
block/backup.c | 454 +++++----------------
block/block-copy.c | 337 ++++++++++++++++
block/io.c | 68 +++-
block/replication.c | 2 +-
blockdev.c | 1 +
block/Makefile.objs | 3 +
block/trace-events | 14 +-
tests/qemu-iotests/056 | 8 +-
tests/qemu-iotests/124 | 83 ++--
tests/qemu-iotests/257 | 91 ++---
tests/qemu-iotests/257.out | 714 ++++++++++++++--------------------
tests/qemu-iotests/iotests.py | 27 ++
18 files changed, 1281 insertions(+), 920 deletions(-)
create mode 100644 block/backup-top.h
create mode 100644 include/block/block-copy.h
create mode 100644 block/backup-top.c
create mode 100644 block/block-copy.c
--
2.18.0
- [Qemu-devel] [PATCH v10 00/14] backup-top filter driver for backup,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH v10 07/14] block: teach bdrv_debug_breakpoint skip filters with backing, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 03/14] block/backup: improve comment about image fleecing, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 12/14] block: add lock/unlock range functions, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 01/14] block/backup: fix backup_cow_with_offload for last cluster, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 06/14] block: move block_copy from block/backup.c to separate file, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 02/14] block/backup: split shareable copying part from backup_do_cow, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 09/14] iotests: 257: drop unused Drive.device field, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 10/14] iotests: 257: drop device_add, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 11/14] block/io: refactor wait_serialising_requests, Vladimir Sementsov-Ogievskiy, 2019/08/30
- [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState, Vladimir Sementsov-Ogievskiy, 2019/08/30