[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/19] spapr: Use SHUTDOWN_CAUSE_SUBSYSTEM_RESET for
From: |
David Gibson |
Subject: |
[Qemu-devel] [PULL 16/19] spapr: Use SHUTDOWN_CAUSE_SUBSYSTEM_RESET for CAS reboots |
Date: |
Thu, 29 Aug 2019 16:08:24 +1000 |
The sPAPR platform includes feature negotiation between the guest and
platform. That sometimes requires reconfiguring the virtual hardware, and
in some cases that is a complex enough process that we trigger a system
reset to handle it. That interacts badly with -no-reboot - we trigger the
reboot, -no-reboot means we exit and so the guest never gets to try again.
Eventually we want to get rid of CAS reboots entirely, since they're odd
and irritating for the user. But in the meantime we can fix the -no-reboot
problem by using SHUTDOWN_CAUSE_SUBSYSTEM_RESET which ignores -no-reboot
and seems to be designed for this sort of faux-reset for internal purposes
only.
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/spapr_hcall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index e20a946b99..23e4bdb829 100644
--- a/hw/ppc/spapr_hcall.c
+++ b/hw/ppc/spapr_hcall.c
@@ -1811,7 +1811,7 @@ static target_ulong
h_client_architecture_support(PowerPCCPU *cpu,
spapr_ovec_cleanup(ov5_updates);
if (spapr->cas_reboot) {
- qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET);
+ qemu_system_reset_request(SHUTDOWN_CAUSE_SUBSYSTEM_RESET);
}
return H_SUCCESS;
--
2.21.0
- [Qemu-devel] [PULL 04/19] ppc/pnv: Generate phandle for the "interrupt-parent" property, (continued)
- [Qemu-devel] [PULL 04/19] ppc/pnv: Generate phandle for the "interrupt-parent" property, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 08/19] ppc: Fix xscvdpspn for SNAN, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 10/19] pseries: Fix compat_pvr on reset, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 09/19] spapr_pci: remove all child functions in function zero unplug, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 12/19] target/ppc: Fix do_float_check_status vs inexact, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 13/19] target/ppc: Refactor emulation of vmrgew and vmrgow instructions, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 18/19] spapr/pci: Convert types to QEMU coding style, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 14/19] pseries: Update SLOF firmware image, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 19/19] spapr: Set compat mode in spapr_core_plug(), David Gibson, 2019/08/29
- [Qemu-devel] [PULL 15/19] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 16/19] spapr: Use SHUTDOWN_CAUSE_SUBSYSTEM_RESET for CAS reboots,
David Gibson <=
- [Qemu-devel] [PULL 17/19] spapr_pci: Advertise BAR reallocation capability, David Gibson, 2019/08/29
- [Qemu-devel] [PULL 02/19] ppc/pnv: update skiboot to v6.4, David Gibson, 2019/08/29