[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] block: Let blockdev-create return 0 on succ
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/2] block: Let blockdev-create return 0 on success |
|
Date: |
Tue, 27 Aug 2019 17:15:49 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/23/19 2:47 PM, Max Reitz wrote:
> Jobs are expected to return 0 on success. .bdrv_co_create() on the
> other hand is a block layer function, and as such returns a non-negative
> value on success.
>
> blockdev_create_run() should translate between the two (patch 1).
>
> Without patch 1, blockdev-create is likely to fail for VPC images.
> Hence patch 2.
>
>
> Max Reitz (2):
> block: Let blockdev-create return 0 on success
> iotests: Test blockdev-create for vpc
>
> block/create.c | 3 +-
> tests/qemu-iotests/266 | 182 +++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/266.out | 107 ++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 292 insertions(+), 1 deletion(-)
> create mode 100755 tests/qemu-iotests/266
> create mode 100644 tests/qemu-iotests/266.out
>
Reviewed-by: John Snow <address@hidden>