[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/2] block: Let blockdev-create return 0 on success
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH 1/2] block: Let blockdev-create return 0 on success |
Date: |
Fri, 23 Aug 2019 20:47:32 +0200 |
Block drivers should let their .bdrv_co_create() implementation return a
non-negative value to indicate success. However, jobs should return
exactly 0. Thus, we need to translate positive return values to 0 in
blockdev_create_run().
Cc: address@hidden
Signed-off-by: Max Reitz <address@hidden>
---
block/create.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/create.c b/block/create.c
index 1bd00ed5f8..4b23672e1b 100644
--- a/block/create.c
+++ b/block/create.c
@@ -48,7 +48,8 @@ static int coroutine_fn blockdev_create_run(Job *job, Error
**errp)
qapi_free_BlockdevCreateOptions(s->opts);
- return ret;
+ /* Jobs must return 0 to indicate success */
+ return ret < 0 ? ret : 0;
}
static const JobDriver blockdev_create_job_driver = {
--
2.21.0