[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/13] target/openrisc: Move VR, UPR, DMMCFGR, I
From: |
Stafford Horne |
Subject: |
Re: [Qemu-devel] [PATCH 05/13] target/openrisc: Move VR, UPR, DMMCFGR, IMMCFGR to cpu init |
Date: |
Tue, 27 Aug 2019 13:35:29 +0900 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Mon, Aug 26, 2019 at 05:07:37PM -0700, Richard Henderson wrote:
> These registers are read-only and implementation specific.
> Initiailize VR for the first time; take the OR1200 values
> from the verilog source.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Stafford Horne <address@hidden>
> ---
> target/openrisc/cpu.h | 8 ++++----
> target/openrisc/cpu.c | 23 ++++++++++++++++-------
> target/openrisc/sys_helper.c | 4 ++--
> 3 files changed, 22 insertions(+), 13 deletions(-)
>
> diff --git a/target/openrisc/cpu.h b/target/openrisc/cpu.h
> index 755282f95d..18d7445e74 100644
> --- a/target/openrisc/cpu.h
> +++ b/target/openrisc/cpu.h
> @@ -260,10 +260,6 @@ typedef struct CPUOpenRISCState {
> target_ulong sr_cy; /* the SR_CY bit, values 0, 1. */
> target_long sr_ov; /* the SR_OV bit (in the sign bit only) */
> uint32_t sr; /* Supervisor register, without SR_{F,CY,OV} */
> - uint32_t vr; /* Version register */
> - uint32_t upr; /* Unit presence register */
> - uint32_t dmmucfgr; /* DMMU configure register */
> - uint32_t immucfgr; /* IMMU configure register */
> uint32_t esr; /* Exception supervisor register */
> uint32_t evbar; /* Exception vector base address register */
> uint32_t pmr; /* Power Management Register */
> @@ -283,7 +279,11 @@ typedef struct CPUOpenRISCState {
> struct {} end_reset_fields;
>
> /* Fields from here on are preserved across CPU reset. */
> + uint32_t vr; /* Version register */
> + uint32_t upr; /* Unit presence register */
> uint32_t cpucfgr; /* CPU configure register */
> + uint32_t dmmucfgr; /* DMMU configure register */
> + uint32_t immucfgr; /* IMMU configure register */
Note for me, others, just moving these doesn't require updating the machine
serialization.
- [Qemu-devel] [PATCH 00/13] target/openrisc updates, Richard Henderson, 2019/08/26
- [Qemu-devel] [PATCH 01/13] target/openrisc: Add DisasContext parameter to check_r0_write, Richard Henderson, 2019/08/26
- [Qemu-devel] [PATCH 03/13] target/openrisc: Cache R0 in DisasContext, Richard Henderson, 2019/08/26
- [Qemu-devel] [PATCH 04/13] target/openrisc: Make VR and PPC read-only, Richard Henderson, 2019/08/26
- [Qemu-devel] [PATCH 05/13] target/openrisc: Move VR, UPR, DMMCFGR, IMMCFGR to cpu init, Richard Henderson, 2019/08/26
- Re: [Qemu-devel] [PATCH 05/13] target/openrisc: Move VR, UPR, DMMCFGR, IMMCFGR to cpu init,
Stafford Horne <=
- [Qemu-devel] [PATCH 02/13] target/openrisc: Replace cpu register array with a function, Richard Henderson, 2019/08/26
- [Qemu-devel] [PATCH 06/13] target/openrisc: Add VR2 and AVR special processor registers, Richard Henderson, 2019/08/26
- [Qemu-devel] [PATCH 07/13] target/openrisc: Fix lf.ftoi.s, Richard Henderson, 2019/08/26
- [Qemu-devel] [PATCH 08/13] target/openrisc: Check CPUCFG_OF32S for float insns, Richard Henderson, 2019/08/26
- [Qemu-devel] [PATCH 11/13] target/openrisc: Implement move to/from FPCSR, Richard Henderson, 2019/08/26