Re: [Qemu-devel] [PATCH v5 00/30] riscv: sifive_u: Improve the emulation fidelity of sifive_u machine

[Alistair Francis]

On Fri, Aug 23, 2019 at 10:08 PM Bin Meng <address@hidden> wrote:
>
> Hi Alistair,
>
> On Sat, Aug 24, 2019 at 1:29 AM Alistair Francis <address@hidden> wrote:
> >
> > On Thu, Aug 22, 2019 at 10:15 PM Bin Meng <address@hidden> wrote:
> > >
> > > As of today, the QEMU 'sifive_u' machine is a special target that does
> > > not boot the upstream OpenSBI/U-Boot firmware images built for the real
> > > SiFive HiFive Unleashed board. Hence OpenSBI supports a special platform
> > > "qemu/sifive_u". For U-Boot, the sifive_fu540_defconfig is referenced
> > > in the OpenSBI doc as its payload, but that does not boot at all due
> > > to various issues in current QEMU 'sifive_u' machine codes.
> > >
> > > This series aims to improve the emulation fidelity of sifive_u machine,
> > > so that the upstream OpenSBI, U-Boot and kernel images built for the
> > > SiFive HiFive Unleashed board can be used out of the box without any
> > > special hack.
> > >
> > > The major changes include:
> > > - Heterogeneous harts creation supported, so that we can create a CPU
> > >   that exactly mirrors the real hardware: 1 E51 + 4 U54.
> > > - Implemented a PRCI model for FU540
> > > - Implemented an OTP model for FU540, primarily used for storing serial
> > >   number of the board
> > > - Fixed GEM support that was seriously broken on sifive_u
> > > - Synced device tree with upstream Linux kernel on sifive_u
> > >
> > > OpenSBI v0.4 image built for sifive/fu540 is included as the default
> > > bios image for 'sifive_u' machine.
> > >
> > > The series is tested against OpenSBI v0.4 image for sifive/fu540
> > > paltform, U-Boot v2019.10-rc1 image for sifive_fu540_defconfig,
> > > and Linux kernel v5.3-rc3 image with the following patch:
> > >
> > > macb: Update compatibility string for SiFive FU540-C000 [1]
> > >
> > > OpenSBI + U-Boot, ping/tftpboot with U-Boot MACB driver works well.
> > > Boot Linux 64-bit defconfig image, verified that system console on
> > > the serial 0 and ping host work pretty well.
> > >
> > > An OpenSBI patch [2] was sent to drop the special "qemu/sifive_u" platform
> > > support in OpenSBI. The original plan was to get the drop patch applied
> > > after this QEMU series is merged. However after discussion in the OpenSBI
> > > mailing list, it seems the best option for us is to let OpenSBI continue
> > > shipping the special "qemu/sifive_u" platform support to work with QEMU
> > > version <= 4.1 and deprecate the support sometime in the future. A patch
> > > will need to be sent to OpenSBI mailing list to update its document.
> > >
> > > v4 is now rebased on Palmer's QEMU RISC-V repo "for-master" branch.
> > > Dropped the following v3 patch that was already done by someone else.
> > > - riscv: sifive_u: Generate an aliases node in the device tree
> > > - riscv: sifive_u: Support loading initramfs
> > >
> > > The following v3 patch was dropped too due to a different cluster approach
> > > suggested by Richard Henderson is used in v4:
> > > - riscv: hart: Support heterogeneous harts population
> > >
> > > [1]: https://patchwork.kernel.org/patch/11050003/
> > > [2]: http://lists.infradead.org/pipermail/opensbi/2019-August/000335.html
> > >
> > > Changes in v5:
> > > - new patch to change to use qemu_log_mask(LOG_GUEST_ERROR,...) instead
> > >   in various sifive models
> > > - new patch to remove the unnecessary include of target/riscv/cpu.h
> > > - change to use defines instead of enums
> > > - change to use qemu_log_mask(LOG_GUEST_ERROR,...) in sifive_u_prci
> > > - creating a 32-bit val variable and using that instead of casting
> > >   everywhere in sifive_u_prci_write()
> > > - move all register initialization to sifive_u_prci_reset() function
> > > - drop sifive_u_prci_create()
> > > - s/codes that worked/code that works/g
> > > - create sifive_u_prci block directly in the machine codes, instead
> > >   of calling sifive_u_prci_create()
> > > - change to use defines instead of enums
> > > - change to use qemu_log_mask(LOG_GUEST_ERROR,...) in sifive_u_otp
> > > - creating a 32-bit val variable and using that instead of casting
> > >   everywhere in sifive_u_otp_write()
> > > - move all register initialization to sifive_u_otp_reset() function
> > > - drop sifive_u_otp_create()
> > > - create sifive_u_otp block directly in the machine codes, instead
> > >   of calling sifive_u_otp_create()
> > > - add the missing "local-mac-address" property in the ethernet node
> > >
> > > Changes in v4:
> > > - remove 2 more "linux,phandle" instances in sifive_u.c and spike.c
> > >   after rebasing on Palmer's QEMU RISC-V tree
> > > - change create_fdt() to return void in sifive_u.c too, after rebasing
> > >   on Palmer's QEMU RISC-V tree
> > > - new patch to remove executable attribute of opensbi images
> > > - prefix all macros/variables/functions with SIFIVE_E/sifive_e
> > >   in the sifive_e_prci driver
> > > - new patch to add a "hartid-base" property to RISC-V hart array
> > > - changed to create clusters for each cpu type
> > > - prefix all macros/variables/functions with SIFIVE_U/sifive_u
> > >   in the sifive_u_prci driver
> > > - prefix all macros/variables/functions with SIFIVE_U/sifive_u
> > >   in the sifive_u_otp driver
> > > - new patch to remove handcrafted clock nodes for UART and ethernet
> > >
> > > Changes in v3:
> > > - changed to use macros for management and compute cpu count
> > > - use management cpu count + 1 for the min_cpus
> > > - update IRQ numbers of both UARTs to match hardware as well
> > >
> > > Changes in v2:
> > > - keep the PLIC compatible string unchanged as OpenSBI uses that
> > >   for DT fix up
> > > - drop patch "riscv: sifive: Move sifive_mmio_emulate() to a common place"
> > > - new patch "riscv: sifive_e: Drop sifive_mmio_emulate()"
> > > - fixed the "interrupts-extended" property size
> > > - update the file header to indicate at least 2 harts are created
> > > - use create_unimplemented_device() to create the GEM management
> > >   block instead of sifive_mmio_emulate()
> > > - add "phy-handle" property to the ethernet node
> > >
> > > Bin Meng (30):
> > >   riscv: hw: Remove superfluous "linux,phandle" property
> > >   riscv: hw: Use qemu_fdt_setprop_cell() for property with only 1 cell
> > >   riscv: hw: Remove not needed PLIC properties in device tree
> > >   riscv: hw: Change create_fdt() to return void
> > >   riscv: hw: Change to use qemu_log_mask(LOG_GUEST_ERROR,...) instead
> > >   riscv: hw: Remove the unnecessary include of target/riscv/cpu.h
> > >   riscv: roms: Remove executable attribute of opensbi images
> > >   riscv: sifive_u: Remove the unnecessary include of prci header
> > >   riscv: sifive: Rename sifive_prci.{c,h} to sifive_e_prci.{c,h}
> > >   riscv: sifive_e: prci: Fix a typo of hfxosccfg register programming
> > >   riscv: sifive_e: prci: Update the PRCI register block size
> > >   riscv: sifive_e: Drop sifive_mmio_emulate()
> > >   riscv: Add a sifive_cpu.h to include both E and U cpu type defines
> > >   riscv: hart: Extract hart realize to a separate routine
> > >   riscv: hart: Add a "hartid-base" property to RISC-V hart array
> > >   riscv: sifive_u: Update hart configuration to reflect the real FU540
> > >     SoC
> > >   riscv: sifive_u: Set the minimum number of cpus to 2
> > >   riscv: sifive_u: Update PLIC hart topology configuration string
> > >   riscv: sifive: Implement PRCI model for FU540
> > >   riscv: sifive_u: Generate hfclk and rtcclk nodes
> > >   riscv: sifive_u: Add PRCI block to the SoC
> > >   riscv: sifive_u: Reference PRCI clocks in UART and ethernet nodes
> > >   riscv: sifive_u: Update UART base addresses and IRQs
> > >   riscv: sifive_u: Change UART node name in device tree
> > >   riscv: roms: Update default bios for sifive_u machine
> > >   riscv: sifive: Implement a model for SiFive FU540 OTP
> > >   riscv: sifive_u: Instantiate OTP memory with a serial number
> > >   riscv: sifive_u: Fix broken GEM support
> > >   riscv: sifive_u: Remove handcrafted clock nodes for UART and ethernet
> > >   riscv: sifive_u: Update model and compatible strings in device tree
> >
> > I can't see patch 12 and it looks like it didn't make it to the list either:
> >
> > https://patchew.org/QEMU/address@hidden/
> >
>
> Yes, it did not arrive at the mailing list for some weird unknown
> reason. This was seen in previous version too. Suspect there is
> something wrong with the QEMU mailing list.
>
> But I think you should be able to find that in your inbox. I "bcc"
> another email address of mine when sending patches and confirmed all
> the patches in the series were received.

Ah, you are right. I didn't check my work email for the patch.

I have reviewed the patch.

Alistair

>
> Regards,
> Bin