[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v29 1/8] target/avr: Add outward facing interfac
From: |
Michael Rolnik |
Subject: |
Re: [Qemu-devel] [PATCH v29 1/8] target/avr: Add outward facing interfaces and core CPU logic |
Date: |
Mon, 26 Aug 2019 10:53:18 +0300 |
the commit was originally mine. Then Sarah rearranged it, signed and
submitted. She no longer maintains it. So' I believe I can remove her sob.
what do you think?.
Michael
On Mon, Aug 26, 2019 at 10:21 AM Thomas Huth <address@hidden> wrote:
> On 24/08/2019 20.46, Michael Rolnik wrote:
> > From: Sarah Harris <address@hidden>
> >
> > This includes:
> > - CPU data structures
> > - object model classes and functions
> > - migration functions
> > - GDB hooks
> >
> > Signed-off-by: Michael Rolnik <address@hidden>
> > Acked-by: Igor Mammedov <address@hidden>
> > ---
>
> If the patch is originally from Sarah Harris, what happened to her
> "Signed-off-by" line? For new code, it's important to have the S-o-b of
> all contributors documented to make sure that they agreed to the
> "Developer Certificate of Origin". If you made changes in addition to
> Sarah's original code, you can document that with square brackets, e.g.:
>
> Signed-off-by: Sarah Harris <address@hidden>
> [mrolnik: Fixed some bugs in xyz()]
> Signed-off-by: Michael Rolnik <address@hidden>
>
> Thomas
>
--
Best Regards,
Michael Rolnik
[Qemu-devel] [PATCH v29 6/8] target/avr: Add example board configuration, Michael Rolnik, 2019/08/24
[Qemu-devel] [PATCH v29 7/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file, Michael Rolnik, 2019/08/24
[Qemu-devel] [PATCH v29 8/8] target/avr: Add tests, Michael Rolnik, 2019/08/24