[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 12/14] spapr_events: Rewrite a fall through comment
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL 12/14] spapr_events: Rewrite a fall through comment |
Date: |
Wed, 21 Aug 2019 13:19:45 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:
CC ppc64-softmmu/hw/ppc/spapr_rtc.o
hw/ppc/spapr_events.c: In function ‘rtas_event_log_to_source’:
hw/ppc/spapr_events.c:312:12: error: this statement may fall through
[-Werror=implicit-fallthrough=]
312 | if (spapr_ovec_test(spapr->ov5_cas, OV5_HP_EVT)) {
| ^
hw/ppc/spapr_events.c:317:5: note: here
317 | case RTAS_LOG_TYPE_EPOW:
| ^~~~
cc1: all warnings being treated as errors
Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.
Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: David Gibson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/ppc/spapr_events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
index 163a6cd25b45..0e4c19523aea 100644
--- a/hw/ppc/spapr_events.c
+++ b/hw/ppc/spapr_events.c
@@ -314,7 +314,7 @@ rtas_event_log_to_source(SpaprMachineState *spapr, int
log_type)
g_assert(source->enabled);
break;
}
- /* fall back to epow for legacy hotplug interrupt source */
+ /* fall through back to epow for legacy hotplug interrupt source */
case RTAS_LOG_TYPE_EPOW:
source = spapr_event_sources_get_source(spapr->event_sources,
EVENT_CLASS_EPOW);
--
2.21.0
- [Qemu-devel] [PULL 05/14] .gitignore: ignore some vhost-user* related files, (continued)
- [Qemu-devel] [PULL 05/14] .gitignore: ignore some vhost-user* related files, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 01/14] test: Use g_strndup instead of plain strndup, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 13/14] hw/display/sm501: Remove unused include, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 07/14] json: Move switch 'fall through' comment to correct place, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 14/14] hw/display: Compile various display devices as common object, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 08/14] hw/dma/omap_dma: Move switch 'fall through' comment to correct place, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 02/14] misc: fix naming scheme of compatiblity arrays, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 11/14] vl: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 03/14] configure: remove obsoleted $sparc_cpu variable, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 06/14] hw/net/e1000: Fix erroneous comment, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 12/14] spapr_events: Rewrite a fall through comment,
Laurent Vivier <=
- [Qemu-devel] [PULL 10/14] target/ppc: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 09/14] hw/ipmi: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 04/14] configure: fix sdl detection using sdl2-config, Laurent Vivier, 2019/08/21
- Re: [Qemu-devel] [PULL 00/14] Trivial branch patches, Peter Maydell, 2019/08/22