[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/14] json: Move switch 'fall through' comment to co
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL 07/14] json: Move switch 'fall through' comment to correct place |
Date: |
Wed, 21 Aug 2019 13:19:40 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:
qobject/json-parser.c: In function ‘parse_literal’:
qobject/json-parser.c:492:24: error: this statement may fall through
[-Werror=implicit-fallthrough=]
492 | case JSON_INTEGER: {
| ^
qobject/json-parser.c:524:5: note: here
524 | case JSON_FLOAT:
| ^~~~
Correctly place the 'fall through' comment.
Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
qobject/json-parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qobject/json-parser.c b/qobject/json-parser.c
index 7d23e12e3379..d083810d3782 100644
--- a/qobject/json-parser.c
+++ b/qobject/json-parser.c
@@ -519,8 +519,8 @@ static QObject *parse_literal(JSONParserContext *ctxt)
}
assert(ret == -ERANGE);
}
- /* fall through to JSON_FLOAT */
}
+ /* fall through to JSON_FLOAT */
case JSON_FLOAT:
/* FIXME dependent on locale; a pervasive issue in QEMU */
/* FIXME our lexer matches RFC 8259 in forbidding Inf or NaN,
--
2.21.0
- [Qemu-devel] [PULL 00/14] Trivial branch patches, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 05/14] .gitignore: ignore some vhost-user* related files, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 01/14] test: Use g_strndup instead of plain strndup, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 13/14] hw/display/sm501: Remove unused include, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 07/14] json: Move switch 'fall through' comment to correct place,
Laurent Vivier <=
- [Qemu-devel] [PULL 14/14] hw/display: Compile various display devices as common object, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 08/14] hw/dma/omap_dma: Move switch 'fall through' comment to correct place, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 02/14] misc: fix naming scheme of compatiblity arrays, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 11/14] vl: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 03/14] configure: remove obsoleted $sparc_cpu variable, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 06/14] hw/net/e1000: Fix erroneous comment, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 12/14] spapr_events: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 10/14] target/ppc: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-devel] [PULL 09/14] hw/ipmi: Rewrite a fall through comment, Laurent Vivier, 2019/08/21