[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: fix naming scheme of compa
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: fix naming scheme of compatiblity arrays |
Date: |
Wed, 21 Aug 2019 10:29:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
Le 08/07/2019 à 22:49, Marc-André Lureau a écrit :
> Since merge 31ed41889e6e13699871040fe089a2884dca46cb ("Merge
> remote-tracking branch
> 'remotes/elmarco/tags/machine-props-pull-request' into staging"), the
> compat arrays are in lowercase.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> docs/devel/migration.rst | 2 +-
> hw/i386/pc_piix.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
> index 220059679a..f7668ae389 100644
> --- a/docs/devel/migration.rst
> +++ b/docs/devel/migration.rst
> @@ -314,7 +314,7 @@ For example:
>
> a) Add a new property using ``DEFINE_PROP_BOOL`` - e.g. support-foo and
> default it to true.
> - b) Add an entry to the ``HW_COMPAT_`` for the previous version that sets
> + b) Add an entry to the ``hw_compat_`` for the previous version that sets
> the property to false.
> c) Add a static bool support_foo function that tests the property.
> d) Add a subsection with a .needed set to the support_foo function
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index c2280c72ef..6a0e29de7c 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -313,7 +313,7 @@ else {
> * pc_compat_*() functions that run on machine-init time and
> * change global QEMU state are deprecated. Please don't create
> * one, and implement any pc-*-2.4 (and newer) compat code in
> - * HW_COMPAT_*, PC_COMPAT_*, or * pc_*_machine_options().
> + * hw_compat_*, pc_compat_*, or * pc_*_machine_options().
> */
>
> static void pc_compat_2_3_fn(MachineState *machine)
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: fix naming scheme of compatiblity arrays,
Laurent Vivier <=