[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] test: Use g_strndup instead o
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] test: Use g_strndup instead of plain strndup |
Date: |
Wed, 21 Aug 2019 10:27:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
Le 08/06/2019 à 07:25, address@hidden a écrit :
> Due to memory management rules. See HACKING.
>
> Signed-off-by: Tony Nguyen <address@hidden>
>
> diff --git a/tests/check-qjson.c b/tests/check-qjson.c
> index fa2afcc..07a773e 100644
> --- a/tests/check-qjson.c
> +++ b/tests/check-qjson.c
> @@ -767,7 +767,7 @@ static void utf8_string(void)
> if (*end == ' ') {
> end++;
> }
> - in = strndup(tail, end - tail);
> + in = g_strndup(tail, end - tail);
> str = from_json_str(in, j, NULL);
> g_assert(!str);
> g_free(in);
> diff --git a/tests/migration/stress.c b/tests/migration/stress.c
> index 49a03aa..d9aa4af 100644
> --- a/tests/migration/stress.c
> +++ b/tests/migration/stress.c
> @@ -104,9 +104,9 @@ static int get_command_arg_str(const char *name,
> }
>
> if (end)
> - *val = strndup(start, end - start);
> + *val = g_strndup(start, end - start);
> else
> - *val = strdup(start);
> + *val = g_strdup(start);
> return 1;
> }
>
> @@ -126,10 +126,10 @@ static int get_command_arg_ull(const char *name,
> if (errno || *end) {
> fprintf(stderr, "%s (%05d): ERROR: cannot parse %s value %s\n",
> argv0, gettid(), name, valstr);
> - free(valstr);
> + g_free(valstr);
> return -1;
> }
> - free(valstr);
> + g_free(valstr);
> return 0;
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] test: Use g_strndup instead of plain strndup,
Laurent Vivier <=