[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 08/17] target/arm: Split out rebuild_hflags_aprof
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v5 08/17] target/arm: Split out rebuild_hflags_aprofile |
Date: |
Tue, 20 Aug 2019 14:07:11 -0700 |
Create a function to compute the values of the TBFLAG_ANY bits
that will be cached, and are used by A-profile.
Signed-off-by: Richard Henderson <address@hidden>
---
target/arm/helper.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 0fea62dc12..fc071f95db 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -11068,18 +11068,28 @@ static uint32_t rebuild_hflags_m32(CPUARMState *env,
int fp_el,
return rebuild_hflags_common_32(env, fp_el, mmu_idx, flags);
}
+static uint32_t rebuild_hflags_aprofile(CPUARMState *env)
+{
+ int flags = 0;
+
+ flags = FIELD_DP32(flags, TBFLAG_ANY, DEBUG_TARGET_EL,
+ arm_debug_target_el(env));
+ return flags;
+}
+
static uint32_t rebuild_hflags_a32(CPUARMState *env, int fp_el,
ARMMMUIdx mmu_idx)
{
- return rebuild_hflags_common_32(env, fp_el, mmu_idx, 0);
+ uint32_t flags = rebuild_hflags_aprofile(env);
+ return rebuild_hflags_common_32(env, fp_el, mmu_idx, flags);
}
static uint32_t rebuild_hflags_a64(CPUARMState *env, int el, int fp_el,
ARMMMUIdx mmu_idx)
{
+ uint32_t flags = rebuild_hflags_aprofile(env);
ARMMMUIdx stage1 = stage_1_mmu_idx(mmu_idx);
ARMVAParameters p0 = aa64_va_parameters_both(env, 0, stage1);
- uint32_t flags = 0;
uint64_t sctlr;
int tbii, tbid;
@@ -11224,12 +11234,6 @@ void cpu_get_tb_cpu_state(CPUARMState *env,
target_ulong *pc,
}
}
- if (!arm_feature(env, ARM_FEATURE_M)) {
- int target_el = arm_debug_target_el(env);
-
- flags = FIELD_DP32(flags, TBFLAG_ANY, DEBUG_TARGET_EL, target_el);
- }
-
*pflags = flags;
*cs_base = 0;
}
--
2.17.1
- [Qemu-devel] [PATCH v5 06/17] target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state, (continued)
- [Qemu-devel] [PATCH v5 06/17] target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 03/17] target/arm: Split out rebuild_hflags_common_32, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 09/17] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 04/17] target/arm: Split arm_cpu_data_is_big_endian, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 14/17] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 12/17] target/arm: Add arm_rebuild_hflags, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 13/17] target/arm: Split out arm_mmu_idx_el, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 16/17] target/arm: Rebuild hflags at EL changes and MSR writes, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 05/17] target/arm: Split out rebuild_hflags_m32, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 07/17] target/arm: Split out rebuild_hflags_a32, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 08/17] target/arm: Split out rebuild_hflags_aprofile,
Richard Henderson <=
- [Qemu-devel] [PATCH v5 10/17] target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 11/17] target/arm: Hoist computation of TBFLAG_A32.VFPEN, Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 15/17] target/arm: Add HELPER(rebuild_hflags_{a32, a64, m32}), Richard Henderson, 2019/08/20
- [Qemu-devel] [PATCH v5 17/17] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state, Richard Henderson, 2019/08/20
- Re: [Qemu-devel] [PATCH v5 00/17] target/arm: Reduce overhead of cpu_get_tb_cpu_state, Richard Henderson, 2019/08/20