[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/6] s390x/tcg: Rework MMU selection for inst
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/6] s390x/tcg: Rework MMU selection for instruction fetches |
Date: |
Mon, 19 Aug 2019 11:45:13 +0200 |
On Fri, 16 Aug 2019 10:47:05 +0200
David Hildenbrand <address@hidden> wrote:
> Instructions are always fetched from primary address space, except when
> in home address mode. Perform the selection directly in cpu_mmu_index().
>
> get_mem_index() is only used to perform data access, instructions are
> fetched via cpu_lduw_code(), which translates to cpu_mmu_index(env, true).
>
> We don't care about restricting the access permissions of the TLB
> entries anymore, as we no longer enter PRIMARY entries into the
> SECONDARY MMU. Cleanup related code a bit.
>
> Reviewed-by: Thomas Huth <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/cpu.h | 7 +++++++
> target/s390x/mmu_helper.c | 38 +++++++++++++++-----------------------
> 2 files changed, 22 insertions(+), 23 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>
- [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling, David Hildenbrand, 2019/08/16
- [Qemu-devel] [PATCH v3 1/6] s390x/mmu: Trace the right value if setting/getting the storage key fails, David Hildenbrand, 2019/08/16
- [Qemu-devel] [PATCH v3 2/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug(), David Hildenbrand, 2019/08/16
- [Qemu-devel] [PATCH v3 3/6] s390x/tcg: Rework MMU selection for instruction fetches, David Hildenbrand, 2019/08/16
- Re: [Qemu-devel] [PATCH v3 3/6] s390x/tcg: Rework MMU selection for instruction fetches,
Cornelia Huck <=
- [Qemu-devel] [PATCH v3 4/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE, David Hildenbrand, 2019/08/16
- [Qemu-devel] [PATCH v3 5/6] s390x/mmu: Better storage key reference and change bit handling, David Hildenbrand, 2019/08/16
- [Qemu-devel] [PATCH v3 6/6] s390x/mmu: Factor out storage key handling, David Hildenbrand, 2019/08/16
- Re: [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling, Cornelia Huck, 2019/08/19
- Re: [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling, Cornelia Huck, 2019/08/19