Re: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction

[David Gibson]

On Wed, Aug 14, 2019 at 11:34:13AM -0500, Paul Clarke wrote:
> Should these 'checkpatch' ERRORs be addressed, even if it will diverge the 
> code style from the existing, surrounding code?
> 
> On 8/14/19 11:30 AM, address@hidden wrote:
> > This series seems to have some coding style problems. See output below for
> > more information:
> 
> > === OUTPUT BEGIN ===
> > ERROR: code indent should never use tabs
> > #54: FILE: disas/ppc.c:5004:
> > +{ "mffsl",   XRA(63,583,12), XRARB_MASK,^IPOWER9,^I{ FRT } },$
> > 
> > ERROR: space required after that ',' (ctx:VxV)
> > #54: FILE: disas/ppc.c:5004:
> > +{ "mffsl",   XRA(63,583,12), XRARB_MASK,       POWER9, { FRT } },
> >                     ^
> > 
> > ERROR: space required after that ',' (ctx:VxV)
> > #54: FILE: disas/ppc.c:5004:
> > +{ "mffsl",   XRA(63,583,12), XRARB_MASK,       POWER9, { FRT } },

The ones above, no.

> > ERROR: braces {} are necessary for all arms of this statement
> > #148: FILE: target/ppc/translate/fp-impl.inc.c:625:
> > +    if (unlikely(!(ctx->insns_flags2 & PPC2_ISA300)))

But this one, yes.

> > [...]
> > 
> > total: 4 errors, 0 warnings, 115 lines checked
> > 
> > Commit c51c0f894525 (ppc: Add support for 'mffsl' instruction) has style 
> > problems, please review.  If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
> > === OUTPUT END ===
> 
> PC
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature