Re: [Qemu-devel] [PATCH v3] ppc: Add support for 'mffsl' instruction

[Paul Clarke]

Should these 'checkpatch' ERRORs be addressed, even if it will diverge the code 
style from the existing, surrounding code?

On 8/14/19 11:30 AM, address@hidden wrote:
> This series seems to have some coding style problems. See output below for
> more information:

> === OUTPUT BEGIN ===
> ERROR: code indent should never use tabs
> #54: FILE: disas/ppc.c:5004:
> +{ "mffsl",   XRA(63,583,12), XRARB_MASK,^IPOWER9,^I{ FRT } },$
> 
> ERROR: space required after that ',' (ctx:VxV)
> #54: FILE: disas/ppc.c:5004:
> +{ "mffsl",   XRA(63,583,12), XRARB_MASK,       POWER9, { FRT } },
>                     ^
> 
> ERROR: space required after that ',' (ctx:VxV)
> #54: FILE: disas/ppc.c:5004:
> +{ "mffsl",   XRA(63,583,12), XRARB_MASK,       POWER9, { FRT } },
>                         ^
> 
> ERROR: braces {} are necessary for all arms of this statement
> #148: FILE: target/ppc/translate/fp-impl.inc.c:625:
> +    if (unlikely(!(ctx->insns_flags2 & PPC2_ISA300)))
> [...]
> 
> total: 4 errors, 0 warnings, 115 lines checked
> 
> Commit c51c0f894525 (ppc: Add support for 'mffsl' instruction) has style 
> problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> === OUTPUT END ===

PC