[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp(
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp() |
Date: |
Tue, 13 Aug 2019 19:38:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/13/19 5:20 PM, Eric Blake wrote:
> On 8/13/19 4:30 AM, Thomas Huth wrote:
>> No test is using hmp() anymore, and since this function uses the disliked
>> global_qtest variable, we should also make sure that nobody adds new code
>> with this function again. qtest_hmp() should be used instead.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>> tests/libqtest.c | 11 -----------
>> tests/libqtest.h | 10 ----------
>> 2 files changed, 21 deletions(-)
>
> Yay.
>
> We could, at a later time, introduce a patch to do s/qtest_hmp/hmp/ if
> it was deemed worthwhile, but I'm not sure it's worth the churn.
Actually, I like the qtest_* prefix for the libqtest functions - so it
is clear at the first sight that a function is part of libqtest or
rather the test itself.
> Reviewed-by: Eric Blake <address@hidden>
Thanks a lot!
Thomas
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/6] First batch of global_qtest-removement patches for QEMU 4.2, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 2/6] tests/libqos: Make virtio-pci code independent from global_qtest, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 1/6] tests/libqos: Make generic virtio code independent from global_qtest, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp(), Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 4/6] tests/libqtest: Clean up qtest_cb_for_every_machine() wrt global_qtest, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 5/6] tests/libqtest: Make qtest_qmp_device_add/del independent from global_qtest, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 6/6] tests/libqtest: Make qmp_assert_success() independent from global_qtest, Thomas Huth, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/6] First batch of global_qtest-removement patches for QEMU 4.2, Stefan Hajnoczi, 2019/08/13