[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp()
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp() |
Date: |
Tue, 13 Aug 2019 11:30:44 +0200 |
No test is using hmp() anymore, and since this function uses the disliked
global_qtest variable, we should also make sure that nobody adds new code
with this function again. qtest_hmp() should be used instead.
Signed-off-by: Thomas Huth <address@hidden>
---
tests/libqtest.c | 11 -----------
tests/libqtest.h | 10 ----------
2 files changed, 21 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 3c5c3f49d8..3e9245d4c9 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -1130,17 +1130,6 @@ void qmp_assert_success(const char *fmt, ...)
qobject_unref(response);
}
-char *hmp(const char *fmt, ...)
-{
- va_list ap;
- char *ret;
-
- va_start(ap, fmt);
- ret = qtest_vhmp(global_qtest, fmt, ap);
- va_end(ap);
- return ret;
-}
-
bool qtest_big_endian(QTestState *s)
{
return s->big_endian;
diff --git a/tests/libqtest.h b/tests/libqtest.h
index cadf1d4a03..0009b65791 100644
--- a/tests/libqtest.h
+++ b/tests/libqtest.h
@@ -687,16 +687,6 @@ static inline void qmp_eventwait(const char *event)
return qtest_qmp_eventwait(global_qtest, event);
}
-/**
- * hmp:
- * @fmt...: HMP command to send to QEMU, formats arguments like sprintf().
- *
- * Send HMP command to QEMU via QMP's human-monitor-command.
- *
- * Returns: the command's output. The caller should g_free() it.
- */
-char *hmp(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
-
/**
* get_irq:
* @num: Interrupt to observe.
--
2.18.1
- [Qemu-devel] [PATCH 0/6] First batch of global_qtest-removement patches for QEMU 4.2, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 2/6] tests/libqos: Make virtio-pci code independent from global_qtest, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 1/6] tests/libqos: Make generic virtio code independent from global_qtest, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp(),
Thomas Huth <=
- [Qemu-devel] [PATCH 4/6] tests/libqtest: Clean up qtest_cb_for_every_machine() wrt global_qtest, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 5/6] tests/libqtest: Make qtest_qmp_device_add/del independent from global_qtest, Thomas Huth, 2019/08/13
- [Qemu-devel] [PATCH 6/6] tests/libqtest: Make qmp_assert_success() independent from global_qtest, Thomas Huth, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/6] First batch of global_qtest-removement patches for QEMU 4.2, Stefan Hajnoczi, 2019/08/13