|
| From: | Alex Bennée |
| Subject: | Re: [Qemu-devel] [PATCH v4 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h |
| Date: | Mon, 12 Aug 2019 16:00:36 +0100 |
| User-agent: | mu4e 1.3.4; emacs 27.0.50 |
Markus Armbruster <address@hidden> writes: > Alex Bennée <address@hidden> writes: > >> Markus Armbruster <address@hidden> writes: >> >>> In my "build everything" tree, changing sysemu/sysemu.h triggers a >>> recompile of some 1800 out of 6600 objects (not counting tests and >>> objects that don't depend on qemu/osdep.h, down from 5400 due to the >>> previous commit). >>> >>> Several headers include sysemu/sysemu.h just to get typedef >>> VMChangeStateEntry. Move it from sysemu/sysemu.h to qemu/typedefs.h. >>> Spell its structure tag the same while there. Drop the now >>> superfluous includes of sysemu/sysemu.h from headers. >> >> You should probably mention you also fix the struct definition to meet >> our coding style. Otherwise: > > I did: "Spell its structure tag the same while there." Would you like > to suggest a better wording? Apologies - my eyes obviously glazed over that part... > >> Reviewed-by: Alex Bennée <address@hidden> > > Thanks! -- Alex Bennée
| [Prev in Thread] | Current Thread | [Next in Thread] |