[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/29] Include migration/qemu-file-types.h a
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/29] Include migration/qemu-file-types.h a lot less |
Date: |
Mon, 12 Aug 2019 12:48:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/12/19 7:23 AM, Markus Armbruster wrote:
> In my "build everything" tree, changing migration/qemu-file-types.h
> triggers a recompile of some 2600 out of 6600 objects (not counting
> tests and objects that don't depend on qemu/osdep.h).
>
> The culprit is again hw/hw.h, which supposedly includes it for
> convenience.
>
> Include migration/qemu-file-types.h only where it's needed. Touching
> it now recompiles less than 200 objects.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/hw/hw.h | 1 -
> include/migration/cpu.h | 1 +
> hw/acpi/piix4.c | 1 +
> hw/block/virtio-blk.c | 1 +
> hw/char/virtio-serial-bus.c | 1 +
> hw/display/virtio-gpu.c | 1 +
> hw/intc/apic_common.c | 1 +
> hw/intc/s390_flic_kvm.c | 1 +
> hw/nvram/eeprom93xx.c | 1 +
> hw/nvram/fw_cfg.c | 1 +
> hw/pci-host/piix.c | 1 +
> hw/pci/msix.c | 1 +
> hw/pci/pci.c | 1 +
> hw/pci/shpc.c | 1 +
> hw/ppc/spapr.c | 1 +
> hw/s390x/s390-skeys.c | 1 +
> hw/s390x/tod.c | 1 +
> hw/s390x/virtio-ccw.c | 1 +
> hw/scsi/mptsas.c | 1 +
> hw/scsi/scsi-bus.c | 1 +
> hw/scsi/scsi-disk.c | 1 +
> hw/scsi/scsi-generic.c | 1 +
> hw/scsi/virtio-scsi.c | 1 +
> hw/timer/i8254_common.c | 1 +
> hw/timer/twl92230.c | 1 +
> hw/usb/redirect.c | 1 +
> hw/virtio/vhost.c | 1 +
> hw/virtio/virtio-mmio.c | 1 +
> hw/virtio/virtio-pci.c | 1 +
> hw/virtio/virtio.c | 1 +
> target/ppc/kvm.c | 1 +
> 31 files changed, 30 insertions(+), 1 deletion(-)
- Re: [Qemu-devel] [PATCH v4 11/29] typedefs: Separate incomplete types and function types, (continued)
- [Qemu-devel] [PATCH v4 02/29] Include generated QAPI headers less, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 06/29] trace: Eliminate use of TARGET_FMT_plx, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 13/29] Clean up inclusion of exec/cpu-common.h, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 05/29] queue: Drop superfluous #include qemu/atomic.h, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 03/29] qapi: Split error.json off common.json, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 14/29] migration: Move the VMStateDescription typedef to typedefs.h, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 09/29] Include migration/qemu-file-types.h a lot less, Markus Armbruster, 2019/08/12
- Re: [Qemu-devel] [PATCH v4 09/29] Include migration/qemu-file-types.h a lot less,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v4 17/29] Include qom/object.h slightly less, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 25/29] numa: Move remaining NUMA declarations from sysemu.h to numa.h, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 23/29] numa: Don't include hw/boards.h into sysemu/numa.h, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 24/29] Include sysemu/hostmem.h less, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 19/29] Include qemu/queue.h slightly less, Markus Armbruster, 2019/08/12
- [Qemu-devel] [PATCH v4 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h, Markus Armbruster, 2019/08/12
- Re: [Qemu-devel] [PATCH v4 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h, Philippe Mathieu-Daudé, 2019/08/12